Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2031897
estimated_timeintemplate/en/default/bug/create/create.html.tmplisrendered as a hand-written input with no
id, while its label comes frombug/field-label.html.tmpl, which emits<label for="estimated_time">.The label therefore referenced nothing, leaving the control without an
accessible name. Adding the
idresolves it. The field is only renderedfor users in the time tracking group.
The other three controls named in comment 0 were checked and do not need
changes:
#att-datainattachment/createformcontents.html.tmplishiddenand
aria-hidden="true". It is a base64 carrier for the uploader, nota user-facing control, so it is not exposed to assistive technology.
#comment-previewinBugModal/new_comment.html.tmplis a tabpaneldivwithrole="tabpanel"andaria-labelledby. It is not alabelable element and already has an accessible name.
#commentreceivesid = "comment"frombug/comment.html.tmpl, sothe
<label for="comment">at line 555 of the create form resolvescorrectly.
I also checked the remaining hand-written controls on the create form.
short_descalready sets itsidon a continuation line, and the twopush buttons take their accessible name from their
valueattribute, soestimated_timewas the only outstanding case.Confirmed present on current main, which answers comment 1.