impl FromStr for Ipv4Addr #397

Activity

1. AsafFisher commented on Sep 8, 2022

   

   AsafFisher

   on Sep 8, 2022

   ContributorAuthor

   More actions

   Maybe use
   https://docs.rs/no-std-net/latest/no_std_net/struct.Ipv4Addr.html
   ?
2. sunfishcode commented on Sep 8, 2022

   

   sunfishcode

   on Sep 8, 2022

   Member

   More actions

   This only affects the no_std build, because in the std build, rustix's Ipv4Addr is just std::net::Ipv4Addr.

   I think the reason I put these in rustix for the no_std build rather than just using a crate like no-std-net is to make it easier for the port of std to rustix. Using a crate as a dependency of std requires some trickery, and I'm still not sure if I'm doing it right in rustix, so I'm not confident in submitting changes to third-party crates to do it. If porting the code from std is straightforward, that might be the best approach for now.

   This whole issue will hopefully go away in the future; rust-lang/rust#78802 hopefully opens up a path to moving these types into actual core, which should eliminate all these issues.
3. sunfishcode commented on Jan 24, 2025

   

   sunfishcode

   on Jan 24, 2025

   Member

   More actions

   This is now fixed, as rustix's no_std mode now uses the (relatively) new core::net::Ipv4Addr, which supports FromStr.
4. sunfishcode

   closed this as completedon Jan 24, 2025