Conversation
The `sendfile` function, its module declaration, and its re-export were gated on `target_os = "linux"`, which excludes Android. Since Android uses the Linux kernel and its bionic libc provides `sendfile64`, these should be gated on `linux_kernel` instead. This is consistent with the rest of the codebase (e.g. `copy_file_range`, `raw_dir`, `statx`, `ioctl` all use `linux_kernel`) and with `sendfile.rs` itself, which already uses `#[cfg(linux_kernel)]` on the public function. The mismatch meant the module was never compiled on Android despite the function being correctly gated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sendfilefunction, its module declaration, and its re-export were gated ontarget_os = "linux", which excludes Android. Since Android uses the Linux kernel and its bionic libc providessendfile64, these should be gated onlinux_kernelinstead.