Skip to content

Wasmtime: cache_accounts_for_opt_level failing on main #4600

Closed
#4609
Closed
Wasmtime: cache_accounts_for_opt_level failing on main#4600
#4609
Labels
bugIncorrect behavior in the current implementation that needs fixing

Description

@fitzgen
fitzgen
opened on Aug 3, 2022
$ cargo test -p 'wasmtime' engine::tests::cache_accounts_for_opt_level
   Compiling wasmtime-environ v0.40.0 (/home/nick/wasmtime/crates/environ)
   Compiling wasmtime-runtime v0.40.0 (/home/nick/wasmtime/crates/runtime)
   Compiling wasmtime-cranelift v0.40.0 (/home/nick/wasmtime/crates/cranelift)
   Compiling wasmtime-jit v0.40.0 (/home/nick/wasmtime/crates/jit)
   Compiling wasmtime v0.40.0 (/home/nick/wasmtime/crates/wasmtime)
   Compiling wiggle v0.40.0 (/home/nick/wasmtime/crates/wiggle)
   Compiling wasi-common v0.40.0 (/home/nick/wasmtime/crates/wasi-common)
   Compiling wasi-cap-std-sync v0.40.0 (/home/nick/wasmtime/crates/wasi-common/cap-std-sync)
   Compiling wasmtime-wasi v0.40.0 (/home/nick/wasmtime/crates/wasi)
    Finished test [unoptimized + debuginfo] target(s) in 33.10s
     Running unittests src/lib.rs (target/debug/deps/wasmtime-c7705c65c4e36c46)

running 1 test
test engine::tests::cache_accounts_for_opt_level ... FAILED

failures:

---- engine::tests::cache_accounts_for_opt_level stdout ----
thread 'engine::tests::cache_accounts_for_opt_level' panicked at 'called `Result::unwrap()` on an `Err` value: ()', crates/jit/src/debug.rs:147:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    engine::tests::cache_accounts_for_opt_level

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 10 filtered out; finished in 0.03s

error: test failed, to rerun pass '-p wasmtime --lib'

Activity

  1. fitzgen
    added
    bugIncorrect behavior in the current implementation that needs fixing
    on Aug 3, 2022

  2. fitzgen commented on Aug 3, 2022

    @fitzgen
    fitzgen
    on Aug 3, 2022
    MemberAuthor

    This is my HEAD for main:

    commit 301be7438e424a1bcaa5354ebe6d1b73b7f880ac (HEAD -> main, bytecodealliance/main)
Author: Trevor Elliott <telliott@fastly.com>
Date:   Wed Aug 3 13:28:52 2022 -0700

    x64: Begin migrating branch instructions to ISLE (#4587)
    
    https://github.com/bytecodealliance/wasmtime/pull/4587

  3. akirilov-arm commented on Aug 4, 2022

    @akirilov-arm
    akirilov-arm
    on Aug 4, 2022
    Contributor

    I enabled this test on AArch64 in #3606, so after seeing this issue I thought that I had caused a regression, but I just checked, and the test passed when I ran it via ci/run-tests.sh; after that I changed one of the test assertions to use a bogus value to verify that the test was actually running. Curiously, it fails when executed directly, as specified here.

  4. alexcrichton commented on Aug 4, 2022

    @alexcrichton
    alexcrichton
    on Aug 4, 2022
    Member

    Oh that explains why my bisection run on an AArch64 machine points to #3606 as the cause! A bisection on an x86_64 machine points to #4571 and while that is entirely unrelated I think I see the problem so I'll post a fix soon.

  5. alexcrichton
    added 2 commits that reference this issue on Aug 4, 2022

    Shield compiled modules from their appended metadata

    05754d8

    Shield compiled modules from their appended metadata

    acb0759
  6. alexcrichton
    closed this as completedin #4609on Aug 10, 2022
  7. alexcrichton
    added a commit that references this issue on Aug 10, 2022

    Shield compiled modules from their appended metadata (#4609)

    fd28d94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIncorrect behavior in the current implementation that needs fixing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions