Issue 1703 - #1717
Merged
Merged
Issue 1703#1717
Conversation
dicej
reviewed
Sep 22, 2026
dicej
left a comment
dicej
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @asteurer! Looks good overall; just a few suggestions inline.
Also, it would be good to add a simple codegen test which includes a variant case named tag, a resource method named take-handle, etc. to make sure the name conflicts are avoided.
dicej
reviewed
Sep 22, 2026
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com> fix(go): fix variant reserved function name collision Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com> fix(go): fix resource reserved function name collision Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com> fix(go): fix tests and add some doc comments Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com> fix(go): added missing resource doc comments, added --quiet opt, and other misc fixes Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com> fix(go): add testcase and more misc fixes Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
asteurer
force-pushed
the
issue-1703
branch
from
September 22, 2026 16:29
c9eac3a to
5e9bc78
Compare
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
asteurer
force-pushed
the
issue-1703
branch
from
September 22, 2026 16:38
940cd93 to
9124dd4
Compare
Contributor
Author
|
Appreciate your feedback and patience with me @dicej! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1703.
@dicej Should I add extra codegen testcases? I assumed that since this was a set of bugs that would only apply to the Go bindings it wouldn't make sense, but happy to add some if you feel differently.