Skip to content

Add accessor support #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bvisness wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add accessor support #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26489e6
Initial getter/setter support (Rust only)
bvisness Sep 30, 2026
07c8c3e
C++ implementation
bvisness Sep 30, 2026
8b1d834
C impl
bvisness Sep 30, 2026
2d3fbb9
Back to official wasm-tools
bvisness Sep 30, 2026
67609a1
Better TODOs
bvisness Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 40 additions & 40 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ syn = { version = "3.0.5", features = ["printing"] }
futures = "0.3.31"
macro-string = "0.3.0"

wat = "1.259.0"
wasmparser = "0.259.0"
wasm-encoder = "0.259.0"
wasm-metadata = { version = "0.259.0", default-features = false }
wit-parser = "0.259.0"
wit-component = "0.259.0"
wasm-compose = "0.259.0"
wat = "1.260.0"
wasmparser = "0.260.0"
wasm-encoder = "0.260.0"
wasm-metadata = { version = "0.260.0", default-features = false }
wit-parser = "0.260.0"
wit-component = "0.260.0"
wasm-compose = "0.260.0"

wit-bindgen-core = { path = 'crates/core', version = '0.62.0' }
wit-bindgen-c = { path = 'crates/c', version = '0.62.0' }
Expand Down
3 changes: 2 additions & 1 deletion crates/c/src/component_type_object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ pub fn object(
env!("CARGO_PKG_NAME"),
env!("CARGO_PKG_VERSION"),
);
let data = wit_component::metadata::encode(resolve, world, encoding, Some(&producers)).unwrap();
let data =
wit_component::metadata::encode(resolve, world, encoding, Some(&producers), false).unwrap();

// The custom section name here must start with "component-type" but
// otherwise is attempted to be unique here to ensure that this doesn't get
Expand Down
8 changes: 7 additions & 1 deletion crates/core/src/async_.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,13 @@ impl AsyncFilterSet {
FunctionKind::Freestanding
| FunctionKind::Method(_)
| FunctionKind::Static(_)
| FunctionKind::Constructor(_) => false,
| FunctionKind::Constructor(_)
| FunctionKind::Getter
| FunctionKind::MethodGetter(_)
| FunctionKind::StaticGetter(_)
| FunctionKind::Setter
| FunctionKind::MethodSetter(_)
| FunctionKind::StaticSetter(_) => false,
FunctionKind::AsyncFreestanding
| FunctionKind::AsyncMethod(_)
| FunctionKind::AsyncStatic(_) => true,
Expand Down
Loading
Loading