fix(chat): conform tool-views test selector (unbreak main chat:lint)#607
Merged
Conversation
…t rule The chat-tool-views spec's fixture component used selector 'test-weather-card' (added in #600), which fails @angular-eslint/component-selector (must start with 'chat'/'a2ui'). Since the Library CI job lints all libs, this broke chat:lint on main and blocked every PR. Rename to 'chat-test-weather-card' (4 occurrences, test-only, zero runtime impact). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/mainis red: thechat-tool-viewsspec (added in #600) declares a test fixture component withselector: 'test-weather-card', which fails@angular-eslint/component-selector(selectors must start withchat/a2ui). TheLibrary — lint / test / buildCI job lints all libs, so this blocks every PR.Fix: rename
test-weather-card→chat-test-weather-card(4 occurrences in one spec file — the@Componentselector + 3querySelectorassertions). Test-only, zero runtime impact.Verified locally:
nx lint chatexit 0,nx test chatgreen.🤖 Generated with Claude Code