Repository navigation
Sync the incident status after editing or deleting updates in the dashboard - #497
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #494.
Deleting an update from an incident's "Updates" tab left the incident on the deleted update's status. With "Cause identified" then "All fixed", deleting "All fixed" kept the incident Fixed in the list, the API and on the status page, and a Fixed incident can't take new updates to correct it. The tab uses Filament's stock Edit, Delete and bulk Delete actions, which never call
SyncIncidentStatus(the API and MCP paths go throughDeleteUpdate/EditUpdateand are fine).The three actions now run
SyncIncidentStatuson the owning incident afterwards. Schedules are left alone.Tested: three Pest tests in
IncidentResourceTest(delete, bulk delete, edit a status from the tab) fail on main and pass with the change. Full suite in a local PHP 8.5 container: the same 71 failures on main and on this branch (500s from tests that render pages, environment), everything else passes. Pint passes.