Repository navigation
Show and sort incidents without an occurred time by their created time in the dashboard - #498
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
…e in the dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #495.
The incident form says the created time is used when "Occurred at" is left empty, and
Incident::timestampdoes that, but the dashboard read the raw column. Such an incident showed an empty time in the Incidents list and the "Open incidents" widget and was sorted below older incidents, so the newest one ended up last.Both tables now show
timestampand sort bycoalesce(occurred_at, created_at), including the list's column sort.Tested: new tests in
IncidentResourceTestandOpenIncidentsTest(an incident without "Occurred at" is listed before an older one and shows its created time) fail on main and pass with the change. Full suite in a local PHP 8.5 container: the same 71 environment failures on main and on this branch. Pint passes.