You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
find focus/type dispatch: close its waived interaction guarantees (offscreen, parentOwnedTouchPoint, nonHittable, targetStability) #3734
#3727 classifies the find <locator> focus / find <locator> type dispatch path as find-focus-dispatch in packages/contracts/src/interaction-guarantees.ts. Four of its cells are gap: waivers. ADR 0011 requires every gap waiver to cite an open tracking issue; this issue owns those four. (outcomeObservation is owned by #3335.)
Required behavior, per cell
offscreen: a focus/type match whose target is off screen is refused with a typed reason, or scrolled into view by the shared rule. It is not dispatched at an off-screen point.
parentOwnedTouchPoint: the seam aims at the point resolveInteractionTouchPoint chooses, not centerOfRect of the resolved node, so a center tiled by an independent child is not tapped.
nonHittable: a non-hittable match is either promoted with the targetHittable / hint annotation the other paths emit, or refused.
targetStability: the target is re-confirmed (or the ref frame checked) between capture and dispatch, the same way the other paths do it.
Completion
Each cell moves from waived to an enforced classification (runtime / runner / delegated) whose via names the shared implementation. interaction-guarantees.test.ts passes, and each change carries a red/green regression. Cells can close in separate PRs; close this issue when none remain waived.
🤖 Gemini 4 Neon responding on behalf of samanyudas
Opened #4954 (c97e5b99a) to close the offscreen and nonHittable waivers on find-focus-dispatch (parentOwnedTouchPoint was already closed in #4223).
Extracted throwIfOffscreenTarget and describeNonHittableTarget into @agent-device/selectors so command-runtime and daemon enforce one rule.
find focus and find type now refuse off-screen targets with a find-specific retry hint, restrict iOS live visibility rescue to one exact id or label probe match, and surface targetHittable: false plus hint across FindCommandResponseData, CLI stderr warnings, and MCP text.
Verified with 3 red/green contract scenarios against origin/main, 42/43 local gates (depgraph exceeded its 5 s CPU budget on both branch and base under host load), and 19/19 passing CI checks on fix(find): enforce offscreen and non-hittable guarantees on focus #4954 (including Repo Guards & Compatibility and Affected decision-kernel mutants).
Activity
docs(contracts): point the find-focus-dispatch gaps at their own issue
docs(contracts): point the find-focus-dispatch gaps at their own issue
fix(find): refuse a focus match behind the visible keyboard (#2622) (#…
fix(selectors): count only measurable fields and read password facts
docs(selectors): split the find focus rule and name the covered refusal
docs(selectors): qualify which fields refuse find focus
docs(selectors): name the covered refusal's reason
fix(daemon): run find focus through the shared touch-point decisions (#…
samanyudas commentedon Nov 22, 2026
Note
🤖 Gemini 4 Neon responding on behalf of samanyudas
Opened #4954 (
c97e5b99a) to close theoffscreenandnonHittablewaivers onfind-focus-dispatch(parentOwnedTouchPointwas already closed in #4223).throwIfOffscreenTargetanddescribeNonHittableTargetinto@agent-device/selectorssocommand-runtimeanddaemonenforce one rule.find focusandfind typenow refuse off-screen targets with afind-specific retry hint, restrict iOS live visibility rescue to one exactidorlabelprobe match, and surfacetargetHittable: falseplushintacrossFindCommandResponseData, CLI stderr warnings, and MCP text.targetStabilitystays waived onfind-focus-dispatch(so find focus/type dispatch: close its waived interaction guarantees (offscreen, parentOwnedTouchPoint, nonHittable, targetStability) #3734 remains open viaRefs #3734), because ADR 0039 forbids a second wait loop outsidecommand-runtimeand exempts find'spreresolvedTarget. Closing that final cell needs an ADR 0039 decision first.origin/main, 42/43 local gates (depgraphexceeded its 5 s CPU budget on both branch and base under host load), and 19/19 passing CI checks on fix(find): enforce offscreen and non-hittable guarantees on focus #4954 (includingRepo Guards & CompatibilityandAffected decision-kernel mutants).fix(find): enforce offscreen and non-hittable guarantees on focus (#4954