Skip to content

linux plugin: review follow-ups from #4872 #4878

Closed

Description

@thymikee

Follow-ups from the review of #4872 (#4872 (comment) at 7711c47). None blocks the Linux plugin merge.

User-facing:

Plugin boundary:

  • atspi-bridge.ts reads process.platform and the filesystem directly. Route these through PlatformHost.
  • The request-scoped Linux provider (linux-tool-provider.ts:56) has no production producer, and the contract marks clipboard/screenshot/accessibility optional while code dereferences them with !. Drive provider scenarios through a fake PlatformHost and keep the provider plugin-internal. Inline thread: refactor(linux): move Linux desktop automation into the managed platform plugin #4872 (comment)
  • Command lookup (command-runner.ts:88) could become one PlatformHost primitive built on host-kit whichCmd.
  • The detached-exit shape is declared three times; make launchDetached required and remove the refusal the daemon never reaches.
  • The provider is resolved twice (runtime.ts, surface-snapshot.ts).

Measurement:

PlatformHost (from the #4857 review, #4857 (comment)):

  • Make startBackgroundCommand (and launchDetached) required and drop the refusal branches the daemon never reaches (packages/plugins/src/platform.ts, packages/platform-harmonyos/src/command-host.ts:86-90), or drop the "absent when" sentences.

Activity

  1. added this to the 0.22 - lean core milestone on Nov 21, 2026
  2. apex-sentinel-staging commented on Nov 21, 2026

    @apex-sentinel-staging

    Apex Sentinel · Issue review

    Suggested label: feature

    The issue is a checklist of review follow-up work for the Linux plugin, with concrete tasks such as fixing docs anchors, changing provider/PlatformHost boundaries, and tightening command lookup. It describes enhancements and cleanup items rather than a direct user-facing defect, and the tasks are actionable as written.

  3. thymikee commented on Nov 22, 2026

    @thymikee
    MemberAuthor

    Merged in #4948 (e8adbb8 on 0.22): commands.md dismiss-overlay wording, homepage anchor, required clipboard/screenshot/accessibility on the Linux provider, isExecutableOnPath command lookup, required launchDetached/startBackgroundCommand (one detached-exit shape), and the Linux provider resolved once. The AT-SPI helper is now probed through PlatformHost.isFilePresent. Still open: the request-scoped Linux provider has no production producer. Removing it means reshaping test/integration/provider-scenarios/linux-world.ts and src/platform-runtime/request-providers.ts, so it needs a design decision. The measurement item stays with #4591.

  4. thymikee commented on Nov 22, 2026

    @thymikee
    MemberAuthor

    Completed on 0.22: #4948 (e8adbb8) and #4955 (dcbf9d8). The measurement item is tracked in #4591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions