You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Finish the reason-table migration: shared reasons (R7) and enforcement (R8) #4937
Tracks the last two steps of the published-reason migration into ReasonTable rows (pattern from #4904; per-package batches #4922#4924#4928#4930#4932#4934#4936 and R6a).
R7: reasons raised from more than one batch (about 50 values)
Each goes to the lowest contract package every producer already depends on, with every producer moving in one PR. Known sites still holding untyped values, for example in src/ and packages/daemon-client after #4934:
remote_instance_mismatch: packages/daemon-client/src/daemon-client-transport.ts (raise and bare match), daemon, proxy
This is an internal tracking issue for completing the ReasonTable migration, with concrete remaining work for shared reasons and enforcement guard changes, so it is a maintainable enhancement rather than a defect report.
Add to R8: audit every ReasonTable row summary against all sites that publish its value (including helpers that take the reason as a parameter). Reviews on #4932 and #4938 found several summaries written from one emitter only (e.g. swift_cache_untrusted, provider_session_cleanup_incomplete, provider_session_released_during_allocation), so the page described a narrower or wrong cause.
Follow-up from the #4936 review: once #4930 and #4936 merge, move FIND_READ_REASONS (find_snapshot_unreadable) from capture-kit/src/snapshot-quality-verdict.ts into packages/selectors/src/interaction-error.ts beside target_disabled. Both find response builders would read that row, and capture-kit would keep only the capture verdict.
Activity
apex-sentinel-staging commentedon Nov 21, 2026
Apex Sentinel · Issue review
Suggested label:
featureThis is an internal tracking issue for completing the ReasonTable migration, with concrete remaining work for shared reasons and enforcement guard changes, so it is a maintainable enhancement rather than a defect report.
thymikee commentedon Nov 22, 2026
Add to R8: audit every ReasonTable row summary against all sites that publish its value (including helpers that take the reason as a parameter). Reviews on #4932 and #4938 found several summaries written from one emitter only (e.g.
swift_cache_untrusted,provider_session_cleanup_incomplete,provider_session_released_during_allocation), so the page described a narrower or wrong cause.thymikee commentedon Nov 22, 2026
Follow-up from the #4936 review: once #4930 and #4936 merge, move
FIND_READ_REASONS(find_snapshot_unreadable) fromcapture-kit/src/snapshot-quality-verdict.tsintopackages/selectors/src/interaction-error.tsbesidetarget_disabled. Both find response builders would read that row, and capture-kit would keep only the capture verdict.