Skip to content

Require the lease id for provider artifacts after the provider lease ends #4950

Open

Description

@thymikee

#4945 binds leased artifacts and diagnostics records to the lease id that produced them (ADR 0007). One route still serves leased output by tenant only.

Provider artifacts after release. packages/daemon/src/sessions/handlers/lease.ts checks the lease id while the provider lease is active (assertRequestHoldsActiveProviderLease). After release, the provider-session lookup checks only the tenant. Another client with the same proxy token and tenant label can list the cloud artifacts of a released provider session.

Expected: provider artifacts of a leased session require that lease id after release too, as #4945 does for daemon artifacts. Decide where the released lease id is kept (the ended-lease ledger already holds it).

Found in the review of #4945.

Activity

  1. apex-sentinel-staging commented on Nov 22, 2026

    @apex-sentinel-staging

    Apex Sentinel · Issue review

    Suggested label: bug

    The issue reports existing authorization behavior that is wrong: after a provider lease is released, the provider-session lookup checks only tenant, allowing another client with the same proxy token and tenant to list cloud artifacts. It identifies a concrete route/file and expected fix, so a maintainer can act on it.

    Required sections

    • Steps to reproduce (missing)
    • Expected and actual behavior (missing)
    • Version or environment (missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions