Skip to content

Share session visibility rules for public-network callers #4960

Open

Description

@thymikee

Purpose

Use one session visibility rule for session_list and session names in command replies. PR #4953 adds a public-network check for reply names. A public-network caller without tenant isolation can still see unleased local sessions in session_list.

Required behavior

  • Apply the public-network admission rule in createSessionVisibilityPredicate.
  • If a request is public-network and has no tenant isolation, list only sessions that match its session scope and lease id.
  • If a request has tenant isolation, keep the tenant match and the lease-id check for leased sessions.
  • Use the same predicate for session names in replies. Keep the local exception for device recovery.

Verification

Through a shared-token proxy without tenant isolation, send session_list with a valid lease id. The result must contain the matching leased session and omit unleased local sessions and sessions with a different lease id. Add a tenant-scoped case and a direct local case to verify their existing results.

Depends on #4953.

Activity

  1. apex-sentinel-staging commented on Nov 22, 2026

    @apex-sentinel-staging

    Apex Sentinel · Issue review

    Suggested label: bug

    The report describes current behavior as incorrect: a public-network caller without tenant isolation can still see unleased local sessions in session_list, while PR #​4953 added the same restriction for reply names. It specifies the predicate to apply and verification steps, so a maintainer can act on it.

    Required sections

    • Steps to reproduce (missing)
    • Expected and actual behavior (missing)
    • Version or environment (missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions