Skip to content

ADR 0040 step 5 — Fence unresolved provider allocations #4969

Open

Description

@thymikee

Keep the contention reservation until the daemon can prove that an unresolved provider allocation is safe to reuse.

ADR 0040

Required behavior

  • On failed or canceled allocation, retain the ending reservation while provider creation or release is unresolved. If creation succeeds late, release that exact instance.
  • Delete the registry-forget paths that discard an unresolved rental. Keep slow provider release outside execution locks after the reservation guards reuse.
  • On restart, recover provider live and pending journals and inspect durable claims before overlapping admission. If release cannot be proved from durable evidence, report release unknown and keep the affected scope fenced.

Verification

Use barriers for failed first allocation, late success after cancellation, overlapping allocation, provider release failure, and restart. Verify once-only release when the exact identity is recoverable. Verify contention when release is uncertain.

Related work

Use the existing recovery records. The durable rental journal is tracked in a separate issue.

Depends on the lease end reservation in step 4.

Activity

  1. apex-sentinel-staging commented on Nov 22, 2026

    @apex-sentinel-staging

    Apex Sentinel · Issue review

    Suggested label: feature

    The issue specifies required implementation changes for ADR 0040 step 5, including retaining reservations, removing registry-forget paths, recovery behavior, and verification steps; it is a clear enhancement/task rather than a user-reported defect.

  2. thymikee commented on Nov 22, 2026

    @thymikee
    MemberAuthor

    When this step lands, amend the ADR that ADR 0040 (#4964) lists for it in its Amendments table, in the same PR. ADR 0040 does not edit those ADRs up front, because an ADR states the current truth and the code has not changed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions