fix(bench): waive help-conformance coverage for ios-system-ui topic - #1440
Closed
thymikee wants to merge 1 commit into
Closed
fix(bench): waive help-conformance coverage for ios-system-ui topic#1440thymikee wants to merge 1 commit into
thymikee wants to merge 1 commit into
Conversation
The ios-system-ui help topic (added in #1395) has neither a benchmark case nor a waiver, which was breaking the topic-coverage gate on any branch rebased onto main. It documents a simulator-only workflow with known coordinate-fallback and sparse-a11y gaps, so waive it like the existing physical-device/remote topics until those stabilize.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
This PR is stale and should be closed, not merged. Current main already contains the |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ios-system-uihelp topic (added in docs: bless the works-today iOS SpringBoard/widget workflow (#1296 PR A) #1395) had neither a benchmark case inscripts/help-conformance-cases.mjsnor an entry inWAIVED_TOPICS, which fails theevery help topic has a benchmark case or an explicit waivertest — breaking Coverage CI on unrelated PRs rebased ontomain(observed on fix(daemon): keep close-time script-save failures from leaking the session/device claim #1392).ios-system-ui, following the style of the existingphysical-device/remotewaivers: the topic itself documents that it's simulator-only, with known coordinate-fallback steps and a sparse-a11y gallery-search gap, so a stable renderer-pinned benchmark case isn't practical yet.Test plan
npx vitest run scripts/__tests__/help-conformance-topic-coverage.test.ts— 4/4 passing (was 1 failing)npx vitest run scripts/__tests__/help-conformance*— 33/33 passing across all three help-conformance suites