Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
This PR is ready at 2afb5ec. The change now waits for the owned daemon to retire after a request timeout, and I found no problem in the code. Not blocking, and you can take or leave these: (1) the local retirement branch in https://github.com/callstack/agent-device/blob/2afb5ec/src/daemon-client/daemon-client-transport.ts#L269 keys on the public CI is likely unrelated to this change. The Coverage failure is the slow-test gate on I did not run the mutations the PR describes (removing the await, the fallback reservation, the loader accounting). I judged the regression tests from a read of the pre-change code. I could not confirm that #3129 lacks this PR's No conflicts. Before merge, the Coverage failure must be fixed in #3130 by injecting the startup clock or poll budget. Then Smoke should be rerun after #3130 lands. |
180ee97 to
6e44617
Compare
4fd7029 to
814fb0c
Compare
6e44617 to
83de7a2
Compare
814fb0c to
bcce61b
Compare
83de7a2 to
745589d
Compare
745589d to
d2c7a19
Compare
bcce61b to
50eafe5
Compare
|
Consolidated into #3127 as part of reducing #3116 to seven PRs. The composition preserves the complete pre-consolidation source tree, including tests and later review corrections. This PR is superseded; its review discussion and native evidence remain available. Outstanding findings transfer to the owning keeper in the implementation record. |
|
Summary
A local request timeout could remove daemon metadata before its daemon exited. Socket and HTTP timeouts now await the same ownership-checked retirement operation before reporting reset. Unconfirmed exit retains state and is included in the primary timeout error.
Removes the client’s raw metadata-removal and takeover-stop exports. Read-only command policies, remote behavior, Apple runner pattern bytes and request fallback rules stay intact. Health probes reserve time for a fallback and count requester loading and response completion within their budget.
Depends on #3130. Ref #3116. Eight files, 616 gross changed lines; production: 107 additions/143 deletions. The final enforcement commit acknowledges one implementation-only health-reader change, with no RPC payload or protocol-version change.
Validation
Tested
2afb5ec51ab198cc380f6db6a2c6d88d44965241:pnpm check:quick, Fallow, andpnpm check:affected --base fix/daemon-startup-contention --runpass; 925 related tests.