fix: retire only the captured expired session lifetime

[thymikee]

Summary

For #3116, lease expiry now passes one captured SessionRef through teardown and retirement. A cwd-scoped session keeps its stored address; cleanup cannot bind a separate default session or delete a successor published during cleanup. Lease renewal patches the same lifetime's latest record.

Addresses the scoped-expiry review on #3137. Depends on #3138.

Validation

Head: a037cd67f5; five changed files. All locally runnable affected checks pass, including 224 files/1,293 related tests. The 41 focused tests pass without skips; the existing expiry test moved unchanged. Both public-name lookup and unguarded-retirement mutants fail, then restore green. Lint, typecheck, format and Fallow pass. Independent read-only audit found no actionable findings. Device CI remains GitHub-authoritative.

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	4.96 MB	4.96 MB	+17 B
Package (unpacked)	4.96 MB	4.96 MB	+17 B
Package (download)	1.49 MB	1.49 MB	+12 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	26.3 ms	26.5 ms	+0.2 ms
CLI --help	82.0 ms	79.9 ms	-2.1 ms

[cubic-dev-ai]

No issues found across 5 files

_{Re-trigger cubic}

[thymikee]

This PR is ready at a037cd6. The change retires only the captured expired session, and I found nothing that needs to change. All 14 checks pass. This PR is stacked on #3138, so that base branch has to land first. This review covers only the delta from 0780e5e to a037cd6.

Not blocking, and you can take or leave these. At src/daemon/lease-lifecycle.ts#L132 the update callback uses current.lease!. You can spread existingSession.lease, which is already narrowed, instead. At src/daemon/request-execution-scope.ts#L420 runtime hints are now read from ref.address before teardown, and no test sets runtime hints, so seeding them on the original in the 'retire' variant and asserting that finalize receives them would pin that order. At src/daemon/server/daemon-session-idle-expiry.ts#L494 the idle-expiry path still removes by address with delete(sessionName), which fits the #3116 SessionRef retirement follow-up better than this PR.

I did not run the focused tests or your two mutants. I judged that the old code fails the new cases by reading it at 0780e5e. I also did not trace whether finalizeBoundSessionApplicationLifecycle on the captured original could touch a same-device successor in a retire and republish race. That race cannot happen under the current locking, and the old code behaved the same way.

[thymikee]

Consolidated into #3135 as part of reducing #3116 to seven PRs. The composition preserves the complete pre-consolidation source tree, including tests and later review corrections. This PR is superseded; its review discussion and native evidence remain available. Outstanding findings transfer to the owning keeper in the implementation record.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-03 21:17 UTC