Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
This PR is ready at a4b723e. All 14 checks pass on this head, and I know of no conflicts. Not blocking, and you can take or leave it: buildFillResponsePayloads at https://github.com/callstack/agent-device/blob/a4b723e/src/daemon/interaction/internal/interaction-touch-fill.ts#L213 still calls sessionStore.requireCurrent after dispatch, so a lifetime that retires during a fill would throw session_lifetime_ended instead of dropping the reference frame and settle as the touch path now does. A follow-up could use resolveCurrent there, as buildTargetedTouchResponsePayloads does, with a matching retired=true control. I did not run the focused tests or the pre-fix red run, so regression validity comes from reading the base code path. I did not review live device evidence, because the live-session route is unchanged and the new unit control covers the retired path. That control calls buildTargetedTouchResponsePayloads directly, but the press caller passes params straight through, so the bypass is thin. Nothing else is needed before merge, and the PR then lands after the stacked base #3150. The Cubic P3 thread still applies and is optional: #3151 (comment). The retired point touch still runs the reference-frame probe and logs a warning, but the base commit behaves the same, so this is noise and not a regression. |
9902936 to
4dd9c5b
Compare
06cab25 to
de94efd
Compare
4dd9c5b to
7eb2460
Compare
de94efd to
d1db9a5
Compare
4b20874 to
4e91b9e
Compare
d1db9a5 to
14e551c
Compare
4e91b9e to
f52701f
Compare
14e551c to
3e0116c
Compare
3e0116c to
c7da1e8
Compare
|
Consolidated into #3144 as part of reducing #3116 to seven PRs. The composition preserves the complete pre-consolidation source tree, including tests and later review corrections. This PR is superseded; its review discussion and native evidence remain available. Outstanding findings transfer to the owning keeper in the implementation record. |
|
Summary
Selector and coordinate touch response construction now discard settle observations and reference frames when their admitted session lifetime has ended. Both branches read the same current lifetime after any frame probe. Mandatory action finalization still refuses writes to a successor session.
Removed unused captured-record arguments from selector and find capture and touch response construction. The blocked-directory open control now asserts the actual
ENOTDIRerror after native dispatch.Nine files changed. Part of #3116, stacked on #3150; addresses the non-point touch finding on #3148 and optional cleanup on #3145.
Validation
Validated
a4b723e799. The new selector retirement control fails against the pre-fix code (1 failed | 27 passed); all 44 focused controls pass after the fix. Quick and Fallow checks pass. Independent review found no actionable findings.pnpm check:affected --base refactor/session-action-lifetimes --runpasses selected runnable gates and 1,050 related tests across 180 files. CI and the requested live device evidence remain pending.