Skip to content

test(android): wait for the Catalog title before navigation checks - #4624

Merged
thymikee merged 1 commit into
0.22from
fix/android-catalog-readiness-20261117
Nov 17, 2026
Merged

thymikee merged 1 commit into
0.22from
fix/android-catalog-readiness-20261117

Conversation

@thymikee

@thymikee thymikee commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Wait for the fixture's catalog-title after continuing from Automation lab. The prior Catalog substring wait also matched “Continue to catalog” on the previous screen, so it could report readiness early.
  • This three-file test change preserves the 10-second budget, Settings-ref assertion, and navigation. It fixes the independently established readiness ambiguity; the cause of the original Android failure in AWS PR #4617 remains unproven.

Validation

  • Head 8952fe2759f7a2c9f860cdd919974fcb487ed017, base 976b91152554e7eb3c8ecb9ed87534f00dacc306: exact affected gate passed (42 passed, 25 skipped; exactCommit=true), full runnable selection. Node 24.13.0, pnpm 11.17.0; frozen install, build, full format, quick checks, and focused regression (1 passed).
  • The earlier regression failed on wrong-screen acceptance using the internal runtime constructor. The final public-constructor harness passed; an identical final-harness red run was not executed. Independent source review found no actionable findings.
  • Hosted checks at this head completed: 16 successful, one skipped, one neutral, including Android smoke and Coverage. Locally skipped checks are not passes. The original callback, routing, and capture outcome remains unknown.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.14 MB 6.14 MB 0 B
Package (unpacked) 6.14 MB 6.14 MB 0 B
Package (download) 1.86 MB 1.86 MB -8 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 43.2 ms 30.5 ms -12.7 ms
CLI --help 92.0 ms 53.8 ms -38.2 ms

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

No open findings.

Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee
thymikee merged commit e3211ae into 0.22 Nov 17, 2026
18 checks passed
@thymikee
thymikee deleted the fix/android-catalog-readiness-20261117 branch November 17, 2026 09:34
thymikee added a commit that referenced this pull request Nov 19, 2026
thymikee added a commit that referenced this pull request Nov 20, 2026
thymikee added a commit that referenced this pull request Nov 20, 2026
thymikee added a commit that referenced this pull request Nov 21, 2026
thymikee added a commit that referenced this pull request Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant