Repository navigation
ci(ios): overlap device-free smoke setup as one parallel group - #4690
Conversation
The iOS smoke leg ran the simulator boot, the XCTest runner build, and the fixture app restore one after another, although none of the three needs a booted simulator. Move them to one job-level parallel group so the leg pays the slowest member instead of all three. A composite action cannot host a parallel group, and it cannot read the caller's step context, so the group lives in apple.yml and the boot, build, and restore results cross into smoke-ios-run as inputs. The host focus canary stays ahead of the group because the boot can raise the Simulator app, and readiness stays mandatory inside the phase so no step reaches a simulator that is still starting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 6bcdc01. The verdict and the full list are in the summary comment.
The canary used to run inside the iOS phase, so its failure failed the phase. It now runs ahead of the device-free parallel group, and `!cancelled()` does not see a prior step's failure, so the phase would have run roughly 200 s of XCTest, replays, and E2E against a host that cannot hand focus to Finder, and reported a replay failure instead of the cause. Require the canary's outcome in the phase condition, and name it in the host diagnostic trigger and the phase summary, where a hoisted step that failed otherwise shows up only as a skipped phase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The host-diagnostic guard looks the step up by name, so declare the field the workflow parser already returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
This PR is ready at 8a2c399. The iOS smoke job passed at this head, and that run went through the new parallel group, so the changed route was exercised. There are no conflicts. Not blocking, and you can take or leave these: (1) the comment above the group in apple.yml and the PR body say boot, native build and fixture restore ran one after another, but since #3836 the boot already overlapped the build, so the new overlap is fixture restore with the runner build and the saving is about 25-30 s, not more; (2) the saving rests on one PR run (244 s against 234-252 s on four main runs), so a median of at least three head runs against the main median would show it; (3) smoke-ios-run could drop the No red run of the group exists yet, so sibling cancellation and outcome values are shown only by the workflow semantics. The canary thread (#4690 (comment)) is fixed at this head, so please resolve it. |
Summary
Three
Smoke Tests (ios)steps ran in sequence although none needs a booted simulator: runner build (31.2 s median, 24.4-38.1), fixture restore (29.2 s, 22.7-38.7), simulator boot (5.2 s). They share no outputs and write disjoint paths, so they now run as one job-levelparallel:group and the leg pays the slowest member.android.ymlalready does this.A composite cannot host a
parallel:group or read the caller's step context, so the group lives inapple.ymland its results entersmoke-ios-runas inputs. The host focus canary stays ahead of the group, since the boot can raise the Simulator app, and the phase requires its outcome. Readiness stays mandatory inside the phase.mainruns)Window:
Build the shared CLIend toiOS smoke testsend, both sides. Each run against its own serial equivalent cancels host speed: the overlap saves 35-46 s, all cache hits. Runs: 44303358376, 44306734275.Validation
Head
8a2c399d8f, Apple green on every attempt. A hoisted step that fails surfaces only as a skipped phase, so the phase requires each one's outcome, the diagnostic trigger names them, and the summary prints all four.tsc -b,apple-ci-impact.test.ts(53) andtrusted-fixture-artifact.test.mjs(16) pass.🤖 Generated with Claude Code