Skip to content

chore(scripts): wire check-provider-plugin into package.json scripts - #4706

Merged
thymikee merged 1 commit into
mainfrom
audit/provider-plugin-script
Nov 18, 2026
Merged

thymikee merged 1 commit into
mainfrom
audit/provider-plugin-script

Conversation

@thymikee

@thymikee thymikee commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

scripts/check-provider-plugin.mjs was an orphaned entry point: referenced only by
.fallowrc.json and its own usage comment, with no package.json script, workflow, or doc
mention. It is not dead — provider-plugin PRs still run it manually as the packed-plugin
smoke (PR #3118 introduced it; #3770 ran it against packages/provider-testmu; review
comments on #4579, merged 2026-11-17, still ask for
node scripts/check-provider-plugin.mjs packages/provider-browserstack).

This wires it in instead of deleting it: a check:provider-plugin package.json script,
a mention next to the packed-install smoke guidance in CONTRIBUTING.md, and an updated
usage comment. .fallowrc.json is unchanged. 3 files touched.

Validation

Tested SHA: 8b57ed04b25926dfaa6bc669d2aed1fb84c3382b.

  • pnpm install --frozen-lockfile && pnpm build — pass (worktree setup).
  • pnpm lint — 0 warnings, 0 errors.
  • pnpm format:check — all 5428 files correct.
  • pnpm typecheck — pass.
  • pnpm check:fallow — exit 0 (8 inherited findings suppressed, 0 stale suppressions).
  • npx vitest run --project unit-core test/repo-guards — 23 files, 143 tests passed
    (includes npm-package-scripts.test.ts).
  • npx vitest run --project unit-core scripts/__tests__/fallow-fixture-policy.test.ts — passed.
  • pnpm check:provider-plugin packages/provider-testmu — "Packed @agent-device/testmu:
    isolated install, host-recognized errors, and CLI connect passed."

CI obligations: the serialized gate stage validates the pushed head; not waited on here.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

scripts/check-provider-plugin.mjs was an orphaned entry point referenced only
by .fallowrc.json and its own usage comment, yet provider-plugin PRs still
run it manually (e.g. #4579 asks for node scripts/check-provider-plugin.mjs
on the packed BrowserStack plugin). Expose it as pnpm check:provider-plugin
and document it next to the packed-install smoke guidance in CONTRIBUTING.md.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.40 MB 6.40 MB +71 B
Package (unpacked) 6.40 MB 6.40 MB +71 B
Package (download) 1.94 MB 1.94 MB +16 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 30.4 ms 36.0 ms +5.6 ms
CLI --help 74.3 ms 73.1 ms -1.2 ms

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve · review of 8b57ed0

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (894c80ac681c).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 18, 2026
@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 8b57ed0, and I found no problems in the code. All 25 checks pass, and the diff overlaps no job except script-listing guards like npm-package-scripts. There are no conflicts. Not blocking, and you can take or leave these: CONTRIBUTING.md line 139 could say the plugin supplies test/package-smoke.mjs, because a package without it fails with a bare module-not-found error at scripts/check-provider-plugin.mjs:17, and the new line at 140 leaves "npm can only trust a package that exists, so a maintainer" short on its own, so the paragraph could be reflowed.

@thymikee
thymikee merged commit e58d50f into main Nov 18, 2026
25 checks passed
@thymikee
thymikee deleted the audit/provider-plugin-script branch November 18, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant