Repository navigation
chore(scripts): wire check-provider-plugin into package.json scripts - #4706
Conversation
scripts/check-provider-plugin.mjs was an orphaned entry point referenced only by .fallowrc.json and its own usage comment, yet provider-plugin PRs still run it manually (e.g. #4579 asks for node scripts/check-provider-plugin.mjs on the packed BrowserStack plugin). Expose it as pnpm check:provider-plugin and document it next to the packed-install smoke guidance in CONTRIBUTING.md. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
This PR is ready at 8b57ed0, and I found no problems in the code. All 25 checks pass, and the diff overlaps no job except script-listing guards like npm-package-scripts. There are no conflicts. Not blocking, and you can take or leave these: CONTRIBUTING.md line 139 could say the plugin supplies |
Summary
scripts/check-provider-plugin.mjswas an orphaned entry point: referenced only by.fallowrc.jsonand its own usage comment, with no package.json script, workflow, or docmention. It is not dead — provider-plugin PRs still run it manually as the packed-plugin
smoke (PR #3118 introduced it; #3770 ran it against
packages/provider-testmu; reviewcomments on #4579, merged 2026-11-17, still ask for
node scripts/check-provider-plugin.mjs packages/provider-browserstack).This wires it in instead of deleting it: a
check:provider-pluginpackage.json script,a mention next to the packed-install smoke guidance in
CONTRIBUTING.md, and an updatedusage comment.
.fallowrc.jsonis unchanged. 3 files touched.Validation
Tested SHA:
8b57ed04b25926dfaa6bc669d2aed1fb84c3382b.pnpm install --frozen-lockfile && pnpm build— pass (worktree setup).pnpm lint— 0 warnings, 0 errors.pnpm format:check— all 5428 files correct.pnpm typecheck— pass.pnpm check:fallow— exit 0 (8 inherited findings suppressed, 0 stale suppressions).npx vitest run --project unit-core test/repo-guards— 23 files, 143 tests passed(includes
npm-package-scripts.test.ts).npx vitest run --project unit-core scripts/__tests__/fallow-fixture-policy.test.ts— passed.pnpm check:provider-plugin packages/provider-testmu— "Packed @agent-device/testmu:isolated install, host-recognized errors, and CLI connect passed."
CI obligations: the serialized gate stage validates the pushed head; not waited on here.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.