Skip to content

chore(release): publish the managed platform plugins - #4918

Merged
thymikee merged 2 commits into
0.22from
chore/0.22-publish-managed-plugins
Nov 21, 2026
Merged

thymikee merged 2 commits into
0.22from
chore/0.22-publish-managed-plugins

Conversation

@thymikee

@thymikee thymikee commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

Part of #4866. scripts/release-workspace.mjs packs only public manifests, so core's absence hint could name a plugin no release published. This removes "private": true from the six managed plugins whose npm placeholders and trusted publisher the maintainer has configured: @agent-device/web, @agent-device/vega, @agent-device/harmonyos, @agent-device/linux, @agent-device/maestro and @agent-device/replay. Each manifest now matches the already-public @agent-device/browserstack: license, repository.directory, files, publishConfig.access, and the version the stamp step syncs (maestro and replay carried 0.0.0). Workspace siblings stay in devDependencies, so no packed plugin gains a runtime dependency on a private package.

The completion condition lands as a release check: scripts/release-install-hints.ts prints the packages the optional-platform, provider and replay catalogs tell a user to install, and the pack step fails when one is not among the packages it packs. Verified by hand: re-adding "private": true to @agent-device/vega fails release-workspace.mjs pack.

Follow-ups: #4846 must flip @agent-device/limrun, because its new hint makes the check require it; macOS desktop (#4675) has no package yet.

Validation

Tested at the pushed head on macOS. pnpm lint, pnpm typecheck, pnpm format, pnpm check:layering and full npx vitest run --project unit-core pass. fallow audit --base origin/0.22 is clean once the hint reader is registered as a manual entry point: the pack step runs it as a node --experimental-strip-types subprocess analysis cannot follow. The provider-catalog test covers the exported rows. pnpm check:package passes, and node scripts/release-workspace.mjs pack produced all 14 tarballs, the six above without private or dependencies, with publishConfig.exports applied. Residual risk: CI owns a clean-consumer plugins add of a published nightly.

Removes "private": true from @agent-device/web, @agent-device/vega,
@agent-device/harmonyos, @agent-device/linux, @agent-device/maestro and
@agent-device/replay: the maintainer has published their 0.0.0 placeholders
and configured the npm trusted publisher for release.yml. Completes each
manifest the way @agent-device/browserstack has it: license, repository
directory, files, publishConfig access, and the -dev version release-version
stamps (maestro and replay carried their placeholder 0.0.0).

Part of #4866.
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.14 MB 6.13 MB -9.6 kB
Package (unpacked) 6.14 MB 6.13 MB -9.6 kB
Package (download) 1.87 MB 1.87 MB -2.7 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 20.2 ms 21.1 ms +0.9 ms
CLI --help 38.0 ms 41.3 ms +3.3 ms

@apex-sentinel-staging

This comment has been minimized.

…plugin

Core's absence messages and help print `agent-device plugins add
@agent-device/<name>` for every family and provider moved out of it, so a
hint whose package stays private ships a command that cannot resolve (#4866).
release-install-hints.ts reads the optional-platform, provider and replay
installation catalogs, and the workspace pack step refuses a hint whose
package is not among the manifests it packs.

Part of #4866.
@thymikee
thymikee force-pushed the chore/0.22-publish-managed-plugins branch from 9bff6fe to 8dbe1c3 Compare November 21, 2026 18:40
@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve · review of 8dbe1c3

Since the review of 9bff6fe: 0 new · 0 still open · 0 no longer raised

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (a29f3ea79a59).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 8dbe1c3, and there are no conflicts. CI is green: the only non-passing check is a cancelled Body rules run, and a second Body rules run started at the same time and passed. The code needs no change, and no merge step remains. Not blocking, and each can be taken or left: the new hint gate in scripts/release-workspace.mjs has no PR-time test, so a broken import would only show at the next nightly pack; the replay rows in scripts/release-install-hints.ts are a second copy of the format list that REPLAY_PLUGIN_INSTALLATIONS already owns; the maestro bundle in packages/maestro/tsdown.config.ts ships yaml, undici, ipaddr.js, pngjs and jpeg-js without the license notices that core attaches; and the license and repository order in packages/replay/package.json differs from sibling manifests. A follow-up issue fits all four. Not verified here: npm placeholders and trusted-publisher setup for the six packages, which rest on the PR body; a local build, pack, fallow or package check run; whether PR CI runs release:prepare before merge; and a clean-consumer plugins add of a published nightly, which needs the packages to exist first.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 21, 2026
@thymikee
thymikee merged commit 78ca7b4 into 0.22 Nov 21, 2026
30 of 31 checks passed
@thymikee
thymikee deleted the chore/0.22-publish-managed-plugins branch November 21, 2026 19:08
thymikee added a commit that referenced this pull request Nov 21, 2026
* chore(release): make the managed platform plugins public

Removes "private": true from @agent-device/web, @agent-device/vega,
@agent-device/harmonyos, @agent-device/linux, @agent-device/maestro and
@agent-device/replay: the maintainer has published their 0.0.0 placeholders
and configured the npm trusted publisher for release.yml. Completes each
manifest the way @agent-device/browserstack has it: license, repository
directory, files, publishConfig access, and the -dev version release-version
stamps (maestro and replay carried their placeholder 0.0.0).

Part of #4866.

* chore(gates): fail a release whose install hint names an unpublished plugin

Core's absence messages and help print `agent-device plugins add
@agent-device/<name>` for every family and provider moved out of it, so a
hint whose package stays private ships a command that cannot resolve (#4866).
release-install-hints.ts reads the optional-platform, provider and replay
installation catalogs, and the workspace pack step refuses a hint whose
package is not among the manifests it packs.

Part of #4866.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant