Repository navigation
chore(release): publish the managed platform plugins - #4918
Conversation
Removes "private": true from @agent-device/web, @agent-device/vega, @agent-device/harmonyos, @agent-device/linux, @agent-device/maestro and @agent-device/replay: the maintainer has published their 0.0.0 placeholders and configured the npm trusted publisher for release.yml. Completes each manifest the way @agent-device/browserstack has it: license, repository directory, files, publishConfig access, and the -dev version release-version stamps (maestro and replay carried their placeholder 0.0.0). Part of #4866.
Size Report
Startup median (7 runs, lower is better):
|
This comment has been minimized.
This comment has been minimized.
…plugin Core's absence messages and help print `agent-device plugins add @agent-device/<name>` for every family and provider moved out of it, so a hint whose package stays private ships a command that cannot resolve (#4866). release-install-hints.ts reads the optional-platform, provider and replay installation catalogs, and the workspace pack step refuses a hint whose package is not among the manifests it packs. Part of #4866.
9bff6fe to
8dbe1c3
Compare
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
This PR is ready at 8dbe1c3, and there are no conflicts. CI is green: the only non-passing check is a cancelled Body rules run, and a second Body rules run started at the same time and passed. The code needs no change, and no merge step remains. Not blocking, and each can be taken or left: the new hint gate in scripts/release-workspace.mjs has no PR-time test, so a broken import would only show at the next nightly pack; the replay rows in scripts/release-install-hints.ts are a second copy of the format list that |
* chore(release): make the managed platform plugins public Removes "private": true from @agent-device/web, @agent-device/vega, @agent-device/harmonyos, @agent-device/linux, @agent-device/maestro and @agent-device/replay: the maintainer has published their 0.0.0 placeholders and configured the npm trusted publisher for release.yml. Completes each manifest the way @agent-device/browserstack has it: license, repository directory, files, publishConfig access, and the -dev version release-version stamps (maestro and replay carried their placeholder 0.0.0). Part of #4866. * chore(gates): fail a release whose install hint names an unpublished plugin Core's absence messages and help print `agent-device plugins add @agent-device/<name>` for every family and provider moved out of it, so a hint whose package stays private ships a command that cannot resolve (#4866). release-install-hints.ts reads the optional-platform, provider and replay installation catalogs, and the workspace pack step refuses a hint whose package is not among the manifests it packs. Part of #4866.
Summary
Part of #4866.
scripts/release-workspace.mjspacks only public manifests, so core's absence hint could name a plugin no release published. This removes"private": truefrom the six managed plugins whose npm placeholders and trusted publisher the maintainer has configured:@agent-device/web,@agent-device/vega,@agent-device/harmonyos,@agent-device/linux,@agent-device/maestroand@agent-device/replay. Each manifest now matches the already-public@agent-device/browserstack: license,repository.directory,files,publishConfig.access, and the version the stamp step syncs (maestroandreplaycarried0.0.0). Workspace siblings stay indevDependencies, so no packed plugin gains a runtime dependency on a private package.The completion condition lands as a release check:
scripts/release-install-hints.tsprints the packages the optional-platform, provider and replay catalogs tell a user to install, and the pack step fails when one is not among the packages it packs. Verified by hand: re-adding"private": trueto@agent-device/vegafailsrelease-workspace.mjs pack.Follow-ups: #4846 must flip
@agent-device/limrun, because its new hint makes the check require it; macOS desktop (#4675) has no package yet.Validation
Tested at the pushed head on macOS.
pnpm lint,pnpm typecheck,pnpm format,pnpm check:layeringand fullnpx vitest run --project unit-corepass.fallow audit --base origin/0.22is clean once the hint reader is registered as a manual entry point: the pack step runs it as anode --experimental-strip-typessubprocess analysis cannot follow. The provider-catalog test covers the exported rows.pnpm check:packagepasses, andnode scripts/release-workspace.mjs packproduced all 14 tarballs, the six above withoutprivateor dependencies, withpublishConfig.exportsapplied. Residual risk: CI owns a clean-consumerplugins addof a published nightly.