Repository navigation
refactor(snapshot): deduplicate system-surface projections and warnings - #4959
Conversation
|
Thanks for the dedupe work here. At 700306f the iOS warning-producer removal looks right, but the PR cannot merge yet because a required check fails. The import in snapshot-baseline.ts changed from type-only to a value import of Not blocking, and fine to take or leave: the system-surface sentence for iOS captures now comes after the other warnings instead of first, so the PR should not call the change byte-identical, or Could the PR keep the iOS warning-producer removal and the daemon-side bundle-id projection, leave Not verified here: the PR body test counts, and any live iOS or Android capture of a system surface. The unchanged warning set rests on a static trace and the existing snapshot and interactor tests. The two Body rules jobs were cancelled by newer runs and do not overlap this diff. Before merge, the eager-closure budget must pass against the merge-base. |
|
Note 🤖 Gemini 4 Neon responding on behalf of samanyudas Addressed in
Verified locally at |
|
Thanks for the update. At 2b8ab94 the earlier findings (#4959 (comment)) are fixed, and this PR is ready. Not blocking, and fine to take or leave: the restored switch in snapshot-baseline.ts has no comment saying it duplicates |
|
Note 🤖 Gemini 4 Neon responding on behalf of samanyudas Applied both non-blocking nits in
|
|
Thanks for the follow-up push. The change since 2b8ab94 is comment-only, so the earlier clean review (#4959 (comment)) still holds for the code. All 15 checks pass, and no conflicts were reported. No live-device or runtime validation is needed for a comment-only change, and nothing else must happen before merge. Not verified here: the code outside the comment-only delta was not re-reviewed beyond the earlier pass. Not blocking, and these can be taken or left: the new exported |
* origin/main: fix(auth): send a stored CLI session only to the cloud that issued it (#4921) refactor(reasons): declare the daemon reasons in ReasonTable rows (#4936) fix(cli): drop --remote-config from auth and skip reading it for unsupported commands (#4957) refactor(snapshot): deduplicate system-surface projections and warnings (#4959) fix(find): enforce offscreen and non-hittable guarantees on focus (#4954) feat(auth): store a rotated CLI session credential and show the login code (#4833) fix(daemon): report Windows SIGTERM daemon exits as forced (#4659) # Conflicts: # packages/capture-kit/src/snapshot-quality-verdict.ts # packages/command-runtime/src/commands/interaction/runtime/target-visibility-stages.ts # packages/contracts/src/device-inventory.ts # packages/daemon/src/execution/interaction/internal/__tests__/find.test.ts # packages/daemon/src/execution/interaction/internal/find-target-capture.ts # packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts # website/docs/docs/error-reasons.md
Summary
Follow-up cleanups from the review of #4956:
systemSurfaceBundleIdbesideSnapshotSystemSurfaceinpackages/contracts/src/snapshot-model.ts(and the snapshot facade) fordeferred-interaction-outcome.ts;snapshot-baseline.tsintentionally keeps its type-only local switch to stay within ADR 0027's eager-closure budget.androidSnapshotSystemSurfaceto map AndroidsystemSurfaceOnlymetadata in one place, used bysnapshot-capture.tsand as the warning-site fallback inruntime/snapshot.tswithout changing stored state.runnerSnapshotWarningsinpackages/platform-apple/src/interactor.ts;systemSurfaceDisclosurenow owns it once (emitted at the sharedbuildSnapshotWarningsslot, matching Android).Value
systemSurfaceBundleIdswitch moved to contracts (snapshot-baseline.tsintentionally keeps its type-only copy for ADR 0027){ kind: 'android-system-overlay' }: 2 -> 1Validation
983ebbc7e: comment-only follow-up on2b8ab943e(pnpm format,pnpm lint,pnpm typecheckpassed;2b8ab943epassedeager-closure-budgets+ 5 targeted unit suites, 1009/1009 tests, and 14/14 CI checks).unit,coverage, andprovider-integrationrun in CI; no live device run needed (no runner/Swift/dispatch changes).Created with Gemini 4 Neon in T3 Code.