Repository navigation
docs(commands): verify a coordinate press with a screenshot diff - #4962
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Thanks for the docs update. At 944b08f the change is ready: the three commands match the documented flags and command surface, and no code changes. Not verified here: the commands were not run on a device, and the doc-prose and doc-links checks were not run locally, so CI owns them. The only red check is Body rules, which was cancelled (not failed) on two runs and does not exercise this docs-only diff, so it needs a re-run. No conflicts. Not blocking, take or leave: the closing sentence at https://github.com/callstack/agent-device/blob/944b08f/website/docs/docs/commands.md#L1032 sends readers to the Screenshots section, which has no retry guidance, while a no-change diff does not prove the press was not dispatched. Pointing it at #retry-after-a-failed-command would fit better. The example could also add |
Summary
A raw-coordinate
pressskips thetarget_still_movingcheck and has no ref to wait on, so nothing answers "did the press land". As offered in the #4297 review, the commands doc now shows the capture-diff pattern next to the coordinate-press paragraph in Interactions:screenshot --out before.png,press 201 500, thendiff screenshot --baseline before.png --out diff.png --json. Docs-only; no behavior or command-surface change.Before / after
No observable change: the page adds one paragraph, one example block, and one cross-link.
Validation
Docs-only, so runtime tests do not apply. At head 944b08f,
node --experimental-strip-types scripts/check-doc-prose.tsreports "doc prose: 33 files clean" (no install needed). CI owns the Prose and doc-links lanes.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.