Skip to content

docs(commands): verify a coordinate press with a screenshot diff - #4962

Merged
thymikee merged 1 commit into
callstack:mainfrom
strzhao:forge/coordinate-press-diff-docs
Nov 22, 2026
Merged

thymikee merged 1 commit into
callstack:mainfrom
strzhao:forge/coordinate-press-diff-docs

Conversation

@strzhao

@strzhao strzhao commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A raw-coordinate press skips the target_still_moving check and has no ref to wait on, so nothing answers "did the press land". As offered in the #4297 review, the commands doc now shows the capture-diff pattern next to the coordinate-press paragraph in Interactions: screenshot --out before.png, press 201 500, then diff screenshot --baseline before.png --out diff.png --json. Docs-only; no behavior or command-surface change.

Before / after

No observable change: the page adds one paragraph, one example block, and one cross-link.

Validation

Docs-only, so runtime tests do not apply. At head 944b08f, node --experimental-strip-types scripts/check-doc-prose.ts reports "doc prose: 33 files clean" (no install needed). CI owns the Prose and doc-links lanes.

🤖 Generated with Claude Code


Start Proof
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff

Co-Authored-By: Claude Code <noreply@anthropic.com>
@thymikee

Copy link
Copy Markdown
Member

Thanks for the docs update. At 944b08f the change is ready: the three commands match the documented flags and command surface, and no code changes. Not verified here: the commands were not run on a device, and the doc-prose and doc-links checks were not run locally, so CI owns them. The only red check is Body rules, which was cancelled (not failed) on two runs and does not exercise this docs-only diff, so it needs a re-run. No conflicts. Not blocking, take or leave: the closing sentence at https://github.com/callstack/agent-device/blob/944b08f/website/docs/docs/commands.md#L1032 sends readers to the Screenshots section, which has no retry guidance, while a no-change diff does not prove the press was not dispatched. Pointing it at #retry-after-a-failed-command would fit better. The example could also add --scale 1 to both captures, as the Screenshots section advises for pixel-diff baselines, or say in one clause why the diff is used for coordinate presses. Nothing else must happen before merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 22, 2026
@thymikee
thymikee merged commit 033ed3f into callstack:main Nov 22, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants