Repository navigation
fix(ios): set default props for the bottom accessory view - #614
Open
oleksandrzavarzin-callstack wants to merge 1 commit into
Open
oleksandrzavarzin-callstack wants to merge 1 commit into
oleksandrzavarzin-callstack wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #607.
In Debug builds on iOS 26+, any
TabViewwithrenderBottomAccessoryViewcrashed on first render:RCTBottomAccessoryComponentViewcreateddefaultPropsininitWithFrame:but never assigned it to_props.This PR assigns it, as
RCTTabViewComponentViewalready does.Results
mainVideos
Example app, iOS 26.5
XuPPM3MoejA0MMg-PUb8_w.mp4
yHo9TqMDazi5bqBkczX1bA.mp4