fix(create-react-native-library): ignore test app artifacts - #952
Open
dcavalcante wants to merge 1 commit into
Open
fix(create-react-native-library): ignore test app artifacts#952dcavalcante wants to merge 1 commit into
dcavalcante wants to merge 1 commit into
Conversation
satya164
requested changes
Sep 8, 2026
Comment on lines
+30
to
+33
| # Generated by CocoaPods for the test app. | ||
| example/ios/*.xcworkspace/ | ||
| # Generated by react-native-test-app and contains the local Node path. | ||
| example/ios/.xcode.env |
Member
There was a problem hiding this comment.
these are ignored for all templates but only relevant for test app, and could be important for other templates. e.g. .xcode.env is intended for source control for regular react native apps.
a better approach maybe to keep the example's .gitignore instead of deleting it to keep example specific ignores.
dcavalcante
force-pushed
the
fix/test-app-ignore-artifacts
branch
from
September 9, 2026 12:35
eb10dee to
2491285
Compare
Author
|
Updated to preserve react-native-test-app’s generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create-react-native-librarygenerates the test app withreact-native-test-app, then removes its generated.gitignore. That loses test-app-specific rules for generated local artifacts.Fix
Preserve the generated
.gitignoreonly for thetest-appexample. Other example flows retain their existing cleanup behavior and manage their own ignore rules where applicable.Validation
example/.gitignore..xcode.envand*.xcworkspace/rules.git diff --check.