Repository navigation
Conversation
krozniata
marked this pull request as ready for review
October 6, 2026 07:01
Member
|
@krozniata regarding nitro, can you reach out to @mrousavy on slack to see what's the plan? |
Contributor
|
I'm already actively working on it :) |
# Conflicts:
# packages/create-react-native-library/templates/objc-view-new/ios/{%- project.name %}View.mm
satya164
reviewed
Oct 22, 2026
| project: { | ||
| ios: { | ||
| automaticPodsInstallation: true, | ||
| automaticPodsInstallation: <%- experimentalSpm ? 'false' : 'true' %>, |
Member
There was a problem hiding this comment.
Via Claude: Once the example is moved to SwiftPM, the generated CI and turbo config still assume CocoaPods:
ci.ymlrunspod install, but after--deintegratethePodfiledoesn't parse anymore (React Native 0.88.0 removesuse_react_native!(and leaves its arguments behind).- A fresh checkout needs
npx react-native spmbefore building, since everything it generates is gitignored (docs). React Native suggests apostinstallscript for this. turbo.jsonlists*.podspecin thebuild:iosinputs but notPackage.swift, so changes to the manifest don't invalidate the cache.
The CI and turbo templates need to handle the SwiftPM case too.
satya164
reviewed
Oct 22, 2026
satya164
reviewed
Oct 22, 2026
satya164
reviewed
Oct 22, 2026
Contributor
|
JFYI Nitro V1 is now on SPM. It dropped CocoaPods support. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an experimental
--experimental-spmflag that generates a Package.swift for Turbo Modules and Fabric views, targeting React Native 0.87's Swift Package Manager supportWhen passing flag it adds
Package.swiftfile to library to support SPM and also disables automatic pod installation in example appAlso adds CI workflows that create such library and build app that uses SPM package ('npx react-native spm --deintegrate`)
Test plan
npx react-native spm --deintegrateAlso CI GREEN