Mark SSO login as removed#8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Livepatch Server documentation to reflect that Ubuntu SSO authentication for admin access has been removed, and to steer users toward Basic Auth/password authentication instead.
Changes:
- Updates the platform configuration reference to state Ubuntu SSO is removed and adds a “removed” subsection for SSO keys.
- Updates the administration tool auth guide to mark Ubuntu SSO as removed and adds a note about using password auth instead.
- Updates reactive→operator migration docs to label
auth.sso.*mappings as removed and add guidance for removing SSO keys during migration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/server/reference/platform/configuration.md | Marks Ubuntu SSO as removed and adds an explicit removed subsection for SSO config keys. |
| docs/server/how-to-guides/security/setup-administration-tool.md | Marks Ubuntu SSO login as removed in the admin tool setup guide. |
| docs/server/how-to-guides/deployment/migrate-from-reactive-charm-to-operator-charm.md | Updates migration mapping table entries to indicate SSO-related keys are removed. |
| docs/server/how-to-guides/deployment/migrate-from-reactive-charm-to-k8s-operator-charm.md | Adds a note warning that migrated configs may include removed auth.sso.* keys. |
Comments suppressed due to low confidence (1)
docs/server/reference/platform/configuration.md:91
- Although this subsection is marked as removed, the option descriptions still read as if Ubuntu SSO can be enabled/configured. To avoid confusion, update the table row descriptions to explicitly state these keys are removed/unsupported.
| `auth.sso.enabled` | Enable Ubuntu SSO authentication. | `bool` |
| `auth.sso.teams` | SSO authentication configuration listing authorised teams. | `https://launchpad.net/~team-1,https://launchpad.net/~team-2` |
| `auth.sso.url` | URL for SSO authentication. | `login.ubuntu.com` |
| `auth.sso.public-key` | Public key for the authentication server. Accepts a file path or an inline key. | `string` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/server/reference/platform/configuration.md:90
- The Ubuntu SSO section is marked as removed, but the config table rows still read as if SSO can be enabled/configured. This is likely to confuse readers; update the descriptions to clearly indicate the keys are removed/ignored (or remove the table entirely if it’s no longer applicable).
| ---- | ----------- | ------ |
| `auth.sso.enabled` | Enable Ubuntu SSO authentication. | `bool` |
| `auth.sso.teams` | SSO authentication configuration listing authorised teams. | `https://launchpad.net/~team-1,https://launchpad.net/~team-2` |
| `auth.sso.url` | URL for SSO authentication. | `login.ubuntu.com` |
| `auth.sso.public-key` | Public key for the authentication server. Accepts a file path or an inline key. | `string` |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: kunalmohan-work <kunal.mohan@canonical.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/server/reference/platform/configuration.md:90
- The
auth.sso.*rows still read as if Ubuntu SSO can be enabled/configured (e.g., "Enable Ubuntu SSO authentication"), which conflicts with the surrounding "removed" messaging. Update the row descriptions to clearly state these keys are removed/ignored.
| `auth.sso.enabled` | Enable Ubuntu SSO authentication. | `bool` |
| `auth.sso.teams` | SSO authentication configuration listing authorised teams. | `https://launchpad.net/~team-1,https://launchpad.net/~team-2` |
| `auth.sso.url` | URL for SSO authentication. | `login.ubuntu.com` |
| `auth.sso.public-key` | Public key for the authentication server. Accepts a file path or an inline key. | `string` |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: kunalmohan-work <kunal.mohan@canonical.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/server/reference/platform/configuration.md:90
- The Ubuntu SSO section says these keys are removed/ignored, but the per-key descriptions still read as if enabling/configuring SSO is supported. This can mislead readers into thinking these options still work; update the table descriptions to explicitly mark them as removed/ignored.
| ---- | ----------- | ------ |
| `auth.sso.enabled` | Enable Ubuntu SSO authentication. | `bool` |
| `auth.sso.teams` | SSO authentication configuration listing authorised teams. | `https://launchpad.net/~team-1,https://launchpad.net/~team-2` |
| `auth.sso.url` | URL for SSO authentication. | `login.ubuntu.com` |
| `auth.sso.public-key` | Public key for the authentication server. Accepts a file path or an inline key. | `string` |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: kunalmohan-work <kunal.mohan@canonical.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/server/reference/platform/configuration.md:90
- This section says
auth.sso.*keys are retained for legacy reference and ignored by the server, but the table row descriptions below still read as if Ubuntu SSO can be enabled/configured. Updating the row descriptions will avoid confusing readers into thinking these keys have effect.
| `auth.sso.enabled` | Enable Ubuntu SSO authentication. | `bool` |
| `auth.sso.teams` | SSO authentication configuration listing authorised teams. | `https://launchpad.net/~team-1,https://launchpad.net/~team-2` |
| `auth.sso.url` | URL for SSO authentication. | `login.ubuntu.com` |
| `auth.sso.public-key` | Public key for the authentication server. Accepts a file path or an inline key. | `string` |
CHANGELOG.mdwith relevant non-documentation file changes?