Repository navigation
Remove unused and obsolete Git service paths - #109
Merged
Merged
Conversation
Remove configured first-push initialization and preserve the one-command local demo by creating its repositories through the API. Update provider coverage and documentation. Co-authored-by: Codex <noreply@openai.com>
Keep explicit unsupported interface methods so go-git cannot fall back to its embedded memory store outside the WAL. Smart HTTP pack import uses RawObjectWriter. Co-authored-by: Codex <noreply@openai.com>
Delete old-ref repair and missing-HEAD substitution. Apply the current ref-name rules to stored catalogs and repository creation, and require persisted branch HEAD in the viewer. Keep recovery for interrupted current-format operations. Co-authored-by: Codex <noreply@openai.com>
carsonfarmer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Git service duplicated repository initialization and retained support for discarded development state. This makes the authenticated
/createAPI the sole initialization path; the local launcher creates its demo repositories through that API. It removes the old-ref repair endpoint and the fallback that inventedmainfor stored roots missing HEAD. Catalogs now require a persisted branch HEAD and current valid ref names; default-branch configuration uses the same name checks. Unsupported old state is rejected, and current interrupted-write recovery remains intact.Two unused go-git storage methods now return
ErrUnsupportedinstead of walking the entire catalog or copying encoded objects. Explicit methods prevent fallback to the embedded memory store outside the WAL. The viewer also rejects missing HEAD while continuing to support valid unborn branches.Go service runtime source: 4,088 → 3,971 lines (-117) across the same 26 files. Removed legacy-readability tests are replaced with current-state rejection coverage.
AGENTS.mdexplicitly prohibits compatibility paths for discarded revisions.Validation passed:
make check, local Spin/MinIO Git-client suite (70.9 seconds), repository isolation, Spin configuration, viewer lint/types/tests/component build, Terraform formatting, and local Caddy admission tests. Independent correctness and simplification reviews found no remaining issues. Five-run lookup/pruning/fetch benchmark medians changed by -0.9% to +4.7%; those paths are unchanged and allocation counts remained stable.Stacked on #104 to keep this reduction diff focused.