Reject empty tag filters as invalid test specifications - #3201
Open
vzer200 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3201 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 206 206
Lines 9031 9039 +8
==========================================
+ Hits 8234 8242 +8
Misses 797 797 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing
[]to SelfTest currently runs all default tests because the empty tag is silently discarded. Reject it as an invalid test specification (exit code 5), including negated filters, combined filters, and empty tags expanded from aliases.Report the original argument once. Track whether the current tag contains any characters so that text left by an earlier argument cannot hide an empty tag. Add parser regressions, a CLI error-handling test, and a versioned documentation note.
Validation on Windows with LLVM-MinGW:
-Wno-error=pointer-bool-conversionflag for an existing Clang 23 warning; no compiler settings are changed in this PR.Prepared with Codex and independently reviewed by a separate agent before submission.
GitHub Issues
Addresses the CLI follow-up in #2367. The original JUnit assertion crash is outside this change.