Pass the parent toolchain to CMake configuration tests - #3202
Open
vzer200 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3202 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 206 206
Lines 9031 9031
=======================================
Hits 8234 8234
Misses 797 797 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Catch2 is configured with a toolchain whose compiler is not on PATH, the CMake configuration tests start child builds without that toolchain and fail to find a compiler. Pass the parent's toolchain to those tests and forward it explicitly to CMake, including versions before 3.21 that do not read the environment variable automatically.
The existing behavior is preserved when no toolchain is configured.
Validation
CMakeConfig::Disablefailure with LLVM MinGW selected only through a toolchain and no compiler on PATH; all four configuration tests pass after the change.all-testsbuild completed. CTest: 143/144 pass; the existing WindowsReporters::CrashInJunitReporterfailure reproduces on the unmodified base. Two unrelated Clang 23 warnings were reproduced on the base and kept as warnings in the local validation toolchain.Implemented and independently reviewed by automated agents before submission.
GitHub Issues
Fixes #2743.