Repository navigation
fix: restore active queue routing - #693
Closed
chrisnestrud wants to merge 1 commit into
Closed
chrisnestrud wants to merge 1 commit into
chrisnestrud wants to merge 1 commit into
Conversation
Restore the foreground-coder resolver lost during the queue merge and route all queue operations through it. Update stale queue tests to retain mock coders and assert current Coder ownership and observable behavior.
|
@chrisnestrud I'm happy to see you tackled this. I was just about to look at fixing it. I noticed sometimes it wouldn't run the queue and sometimes it would only run the first item in the queue. |
dwash96
added a commit
that referenced
this pull request
Sep 26, 2026
Closed
Collaborator
|
Fixing this by making the literal commands actually use the command_queue helper instead of proxying any of this through the command core file |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/insert-queueregressionRationale
Queue state belongs to
Coderso each primary agent and sub-agent has an independent FIFO.Commandsis the adapter for slash commands and should resolve the active coder before operating on that state.The queue ownership migration left
_insert_prompt()calling a missing_active_coder()while the other wrappers bypassed foreground resolution. Restoring the existing resolver fixes/insert-queueand gives every queue operation the same routing rule without duplicating mutable state onCommands.The tests now assert observable queue behavior and current
Coderownership. Obsoletehasattrchecks were removed because they enforced the previous structure without exercising lifecycle behavior.Verification
197 passedacross queue, command, agent-service, subagent-command, and switch-agent tests2103 passed, 9 skipped, 8 failures; the eight failures are existing environment-sensitive tests involving temp directories outside Git,TERM=dumb, and environment-selected model settings