Skip to content

fix: restore active queue routing - #693

Closed
chrisnestrud wants to merge 1 commit into
cecli-dev:mainfrom
chrisnestrud:fix/queue-routing-tests
Closed

chrisnestrud wants to merge 1 commit into
cecli-dev:mainfrom
chrisnestrud:fix/queue-routing-tests

Conversation

@chrisnestrud

Copy link
Copy Markdown

Summary

  • restore foreground-coder resolution for queue commands
  • route insert, enqueue, dequeue, list, remove, and clear through the same coder
  • update stale queue tests to retain weakly referenced mock coders and assert current ownership
  • replace placeholder structure checks with a behavioral /insert-queue regression

Rationale

Queue state belongs to Coder so each primary agent and sub-agent has an independent FIFO. Commands is the adapter for slash commands and should resolve the active coder before operating on that state.

The queue ownership migration left _insert_prompt() calling a missing _active_coder() while the other wrappers bypassed foreground resolution. Restoring the existing resolver fixes /insert-queue and gives every queue operation the same routing rule without duplicating mutable state on Commands.

The tests now assert observable queue behavior and current Coder ownership. Obsolete hasattr checks were removed because they enforced the previous structure without exercising lifecycle behavior.

Verification

  • 197 passed across queue, command, agent-service, subagent-command, and switch-agent tests
  • isort, Black, flake8, and codespell passed
  • complete suite finished with 2103 passed, 9 skipped, 8 failures; the eight failures are existing environment-sensitive tests involving temp directories outside Git, TERM=dumb, and environment-selected model settings

Restore the foreground-coder resolver lost during the queue merge and route all queue operations through it. Update stale queue tests to retain mock coders and assert current Coder ownership and observable behavior.
@szmania

szmania commented Sep 26, 2026

Copy link
Copy Markdown

@chrisnestrud I'm happy to see you tackled this. I was just about to look at fixing it. I noticed sometimes it wouldn't run the queue and sometimes it would only run the first item in the queue.

@dwash96

dwash96 commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Fixing this by making the literal commands actually use the command_queue helper instead of proxying any of this through the command core file

@dwash96 dwash96 closed this Sep 26, 2026
@dwash96 dwash96 mentioned this pull request Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants