refactor: Support user supplied SM count for NVIDIA GPUs - #582
Merged
Conversation
mahendrapaipuri
commented
Aug 15, 2026
Collaborator
- For NVIDIA GPUs, SM count depends on the form factor even for the same GPU model. It is not easy to keep list of all SMs and even if we managed to do it, the way NVIDIA exposes the model name is not standardised, so there is no easy way to map the models to SM count. So, we delegate this task to operators where they can supply SM count for each GPU using CLI argument. When MIG is enabled and this CLI argument is not provided, we emit a warning log so that operators will know that we are using default SM count for current GPUs
* For NVIDIA GPUs, SM count depends on the form factor even for the same GPU model. It is not easy to keep list of all SMs and even if we managed to do it, the way NVIDIA exposes the model name is not standardised, so there is no easy way to map the models to SM count. So, we delegate this task to operators where they can supply SM count for each GPU using CLI argument. When MIG is enabled and this CLI argument is not provided, we emit a warning log so that operators will know that we are using default SM count for current GPUs Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.