Repository navigation
Inline small CEL C++ ByteString and Value methods. - #2333
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_995085211
branch
from
October 7, 2026 18:24
0d1c13a to
53781b8
Compare
Previously, small `ByteString` methods (`Wrap`, `WrapUnsafe`, `SetSmall`, `SetMedium`, `SetLarge`, `empty`, `size`, `GetArena`, `TryFlat`, `AsStringView`, `HashValue`, `Equals`, `Compare`, `StartsWith`, `EndsWith`), `StringValue::Equals`, `StringValue::Equal`, `BytesValue::Equals`, `BytesValue::Equal`, `BoolValue::Equal`, and `Value` scalar accessors (`AsBytes`, `AsDouble`, `AsInt`, `AsString`, `AsUint`, `GetBytes`, `GetDouble`, `GetInt`, `GetString`, `GetUint`) were defined out-of-line across translation units, and `StringValue::Equal` / `BytesValue::Equal` performed nested `NativeValue` visitation instead of delegating to `Equals`. Move these small `ByteString` and `Value` methods inline into their headers and have `StringValue::Equal` and `BytesValue::Equal` delegate directly to `Equals`. PiperOrigin-RevId: 995085211
copybara-service
Bot
force-pushed
the
test_995085211
branch
from
October 7, 2026 18:29
53781b8 to
11924e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline small CEL C++
ByteStringandValuemethods.Previously, small
ByteStringmethods (Wrap,WrapUnsafe,SetSmall,SetMedium,SetLarge,empty,size,GetArena,TryFlat,AsStringView,HashValue,Equals,Compare,StartsWith,EndsWith),StringValue::Equals,StringValue::Equal,BytesValue::Equals,BytesValue::Equal,BoolValue::Equal, andValuescalar accessors (AsBytes,AsDouble,AsInt,AsString,AsUint,GetBytes,GetDouble,GetInt,GetString,GetUint) were defined out-of-line across translation units, andStringValue::Equal/BytesValue::Equalperformed nestedNativeValuevisitation instead of delegating toEquals.Move these small
ByteStringandValuemethods inline into their headers and haveStringValue::EqualandBytesValue::Equaldelegate directly toEquals.