Skip to content

Add unknown benchmarks for the modern API #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 9, 2026
Merged

Add unknown benchmarks for the modern API #2345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eval/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ cc_test(
],
deps = [
":request_context_cc_proto",
"//base:attributes",
"//checker:validation_result",
"//common:decl",
"//common:legacy_value",
Expand Down
175 changes: 175 additions & 0 deletions eval/tests/modern_benchmark_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "absl/status/statusor.h"
#include "absl/strings/match.h"
#include "absl/strings/string_view.h"
#include "base/attribute.h"
#include "checker/validation_result.h"
#include "common/decl.h"
#include "common/native_type.h"
Expand Down Expand Up @@ -80,6 +81,7 @@ using ::google::api::expr::parser::EnrichedParse;
using ::google::api::expr::parser::Parse;
using ::google::api::expr::runtime::RequestContext;
using ::google::rpc::context::AttributeContext;
using ::testing::UnorderedElementsAre;

RuntimeOptions GetOptions() {
RuntimeOptions options;
Expand Down Expand Up @@ -1465,6 +1467,179 @@ void BM_MapTransformComprehension(benchmark::State& state) {

BENCHMARK(BM_MapTransformComprehension)->Range(1, 1 << 16);

void BM_SingleUnknownVariable(benchmark::State& state) {
ASSERT_OK_AND_ASSIGN(ParsedExpr parsed_expr, Parse("unk"));

RuntimeOptions options = GetOptions();
options.unknown_processing = UnknownProcessingOptions::kAttributeOnly;
auto runtime = StandardRuntimeOrDie(options);

ASSERT_OK_AND_ASSIGN(auto program, ProtobufRuntimeAdapter::CreateProgram(
*runtime, parsed_expr));

Activation activation;
ASSERT_THAT(activation.SetUnknownPatterns({AttributePattern("unk")}), IsOk());

for (auto _ : state) {
google::protobuf::Arena arena;
ASSERT_OK_AND_ASSIGN(cel::Value result,
program->Evaluate(&arena, activation));
ASSERT_TRUE(result.IsUnknown());
ASSERT_THAT(result.GetUnknown().ToAttributeSet(),
UnorderedElementsAre(Attribute("unk")));
}
}

BENCHMARK(BM_SingleUnknownVariable);

void BM_DeepUnknownQualifier(benchmark::State& state) {
ASSERT_OK_AND_ASSIGN(
ParsedExpr parsed_expr,
Parse("a.b.c.d.e.f.g.h.i.j.k.l.m.n.o.p.q.r.s.t.u.v.w.x.y.z"));

RuntimeOptions options = GetOptions();
options.unknown_processing = UnknownProcessingOptions::kAttributeOnly;
auto runtime = StandardRuntimeOrDie(options);

ASSERT_OK_AND_ASSIGN(auto program, ProtobufRuntimeAdapter::CreateProgram(
*runtime, parsed_expr));

google::protobuf::Arena arena;
google::protobuf::Arena::UniquePtr<google::protobuf::Struct> struct_value =
google::protobuf::Arena::MakeUnique<google::protobuf::Struct>(&arena);
google::protobuf::Struct* struct_value_ptr = struct_value.get();
for (char l = 'b'; l <= 'z'; ++l) {
auto* fields = struct_value_ptr->mutable_fields();
struct_value_ptr = (*fields)[std::string(1, l)].mutable_struct_value();
}

Attribute attribute(
"a",
{AttributeQualifier::OfString("b"), AttributeQualifier::OfString("c"),
AttributeQualifier::OfString("d"), AttributeQualifier::OfString("e"),
AttributeQualifier::OfString("f"), AttributeQualifier::OfString("g"),
AttributeQualifier::OfString("h"), AttributeQualifier::OfString("i"),
AttributeQualifier::OfString("j"), AttributeQualifier::OfString("k"),
AttributeQualifier::OfString("l"), AttributeQualifier::OfString("m"),
AttributeQualifier::OfString("n"), AttributeQualifier::OfString("o"),
AttributeQualifier::OfString("p"), AttributeQualifier::OfString("q"),
AttributeQualifier::OfString("r"), AttributeQualifier::OfString("s"),
AttributeQualifier::OfString("t"), AttributeQualifier::OfString("u"),
AttributeQualifier::OfString("v"), AttributeQualifier::OfString("w"),
AttributeQualifier::OfString("x"), AttributeQualifier::OfString("y"),
AttributeQualifier::OfString("z")});

Activation activation;
ASSERT_THAT(activation.SetUnknownPatterns({AttributePattern(
"a", {AttributeQualifierPattern::OfString("b"),
AttributeQualifierPattern::OfString("c"),
AttributeQualifierPattern::OfString("d"),
AttributeQualifierPattern::OfString("e"),
AttributeQualifierPattern::OfString("f"),
AttributeQualifierPattern::OfString("g"),
AttributeQualifierPattern::OfString("h"),
AttributeQualifierPattern::OfString("i"),
AttributeQualifierPattern::OfString("j"),
AttributeQualifierPattern::OfString("k"),
AttributeQualifierPattern::OfString("l"),
AttributeQualifierPattern::OfString("m"),
AttributeQualifierPattern::OfString("n"),
AttributeQualifierPattern::OfString("o"),
AttributeQualifierPattern::OfString("p"),
AttributeQualifierPattern::OfString("q"),
AttributeQualifierPattern::OfString("r"),
AttributeQualifierPattern::OfString("s"),
AttributeQualifierPattern::OfString("t"),
AttributeQualifierPattern::OfString("u"),
AttributeQualifierPattern::OfString("v"),
AttributeQualifierPattern::OfString("w"),
AttributeQualifierPattern::OfString("x"),
AttributeQualifierPattern::OfString("y"),
AttributeQualifierPattern::OfString("z")})}),
IsOk());
activation.InsertOrAssignValue(
"a",
cel::Value::WrapMessage(struct_value.get(), runtime->GetDescriptorPool(),
runtime->GetMessageFactory(), &arena));

for (auto _ : state) {
google::protobuf::Arena arena;
ASSERT_OK_AND_ASSIGN(cel::Value result,
program->Evaluate(&arena, activation));
ASSERT_TRUE(result.IsUnknown());
ASSERT_THAT(result.GetUnknown().ToAttributeSet(),
UnorderedElementsAre(attribute));
}
}

BENCHMARK(BM_DeepUnknownQualifier);

void BM_ObnoxiousUnknownQualifier(benchmark::State& state) {
ASSERT_OK_AND_ASSIGN(
ParsedExpr parsed_expr,
Parse("a.b.c.d.e.f.g.h.i.j.k.l.m.n.o.p.q.r.s.t.u.v.w.x.y.z"));

RuntimeOptions options = GetOptions();
options.unknown_processing = UnknownProcessingOptions::kAttributeOnly;
auto runtime = StandardRuntimeOrDie(options);

ASSERT_OK_AND_ASSIGN(auto program, ProtobufRuntimeAdapter::CreateProgram(
*runtime, parsed_expr));

google::protobuf::Arena arena;
google::protobuf::Arena::UniquePtr<google::protobuf::Struct> struct_value =
google::protobuf::Arena::MakeUnique<google::protobuf::Struct>(&arena);
google::protobuf::Struct* struct_value_ptr = struct_value.get();
std::vector<AttributePattern> attributes;
for (char v = 'a'; v <= 'z'; ++v) {
std::vector<AttributeQualifierPattern> qualifiers;
for (char q = 'a'; q <= 'z'; ++q) {
if (v == q) {
continue;
}
qualifiers.push_back(
AttributeQualifierPattern::OfString(std::string(1, q)));
}
attributes.emplace_back(std::string(1, v), std::move(qualifiers));
}
for (char l = 'b'; l <= 'z'; ++l) {
auto* fields = struct_value_ptr->mutable_fields();
struct_value_ptr = (*fields)[std::string(1, l)].mutable_struct_value();
}
Activation activation;
ASSERT_THAT(activation.SetUnknownPatterns(attributes), IsOk());
activation.InsertOrAssignValue(
"a",
cel::Value::WrapMessage(struct_value.get(), runtime->GetDescriptorPool(),
runtime->GetMessageFactory(), &arena));
Attribute attribute(
"a",
{AttributeQualifier::OfString("b"), AttributeQualifier::OfString("c"),
AttributeQualifier::OfString("d"), AttributeQualifier::OfString("e"),
AttributeQualifier::OfString("f"), AttributeQualifier::OfString("g"),
AttributeQualifier::OfString("h"), AttributeQualifier::OfString("i"),
AttributeQualifier::OfString("j"), AttributeQualifier::OfString("k"),
AttributeQualifier::OfString("l"), AttributeQualifier::OfString("m"),
AttributeQualifier::OfString("n"), AttributeQualifier::OfString("o"),
AttributeQualifier::OfString("p"), AttributeQualifier::OfString("q"),
AttributeQualifier::OfString("r"), AttributeQualifier::OfString("s"),
AttributeQualifier::OfString("t"), AttributeQualifier::OfString("u"),
AttributeQualifier::OfString("v"), AttributeQualifier::OfString("w"),
AttributeQualifier::OfString("x"), AttributeQualifier::OfString("y"),
AttributeQualifier::OfString("z")});

for (auto _ : state) {
google::protobuf::Arena arena;
ASSERT_OK_AND_ASSIGN(cel::Value result,
program->Evaluate(&arena, activation));
ASSERT_TRUE(result.IsUnknown());
ASSERT_THAT(result.GetUnknown().ToAttributeSet(),
UnorderedElementsAre(attribute));
}
}

BENCHMARK(BM_ObnoxiousUnknownQualifier);

} // namespace

} // namespace cel
Loading