Enforce recursion depth limits for ternary expressions in the Pratt parser. - #1497
Open
dmitriplotnikov wants to merge 2 commits into
Open
dmitriplotnikov wants to merge 2 commits into
dmitriplotnikov wants to merge 2 commits into
Conversation
dmitriplotnikov
commented
Sep 18, 2026
| return lhs | ||
| } | ||
| p.recursionDepth++ | ||
| defer func() { p.recursionDepth-- }() |
Collaborator
Author
There was a problem hiding this comment.
This turned out quite a bit more expensive than just explicitly decrementing recursionDepth. I am making this adjustment in the second commit in this PR
TristonianJones
approved these changes
Sep 19, 2026
l46kok
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce
MaxRecursionDepthwhen parsing ternary conditional expressions (? :) in the Pratt parser by tracking recursion depth inparseTernaryand terminatingparseBinaryAndTernaryonce the recursion or recovery limit is exceeded.