Generic slice list for improved type guarantees and speed - #1498
Open
TristonianJones wants to merge 1 commit into
Open
TristonianJones wants to merge 1 commit into
TristonianJones wants to merge 1 commit into
Conversation
l46kok
reviewed
Sep 21, 2026
| } | ||
|
|
||
| var newList []ref.Val | ||
| if sliced, ok := types.MaybeSliceList(types.DefaultTypeAdapter, list, int(start), int(end)); ok { |
Collaborator
There was a problem hiding this comment.
Could we add a test case that uses a custom adapter (Proto messages and/or NativeTypes)? I think ordinarily, we want the list to be propagating the same adapter configured from the top-level APIs
(Same ask for reverse)
| if list == nil { | ||
| return nil, false | ||
| } | ||
| val := list.Value() |
Collaborator
There was a problem hiding this comment.
Could you add a few test cases around ensuring that we don't eagerly unwrap the values upon list adaptation here?
([optional.of(1), optional.none()]).reverse()[0] == optional.none()
// Something similar for `concatList`
([optional.of(1)] + [optional.none()]).reverse()[0] == optional.none()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce list generics for CEL to improve iteration performance.
Optimizations also applied to
ext/lists.gowithsliceandreverseshowing 50% gains in perf.Subsequent PRs extend the approach to maps and native types.
#1293