ENT-14195 0. README for cf-reactor event handling - #6352
Merged
Merged
Conversation
victormlg
changed the title
olehermanse
reviewed
Sep 14, 2026
olehermanse
reviewed
Sep 14, 2026
olehermanse
reviewed
Sep 14, 2026
olehermanse
reviewed
Sep 14, 2026
olehermanse
approved these changes
Sep 14, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
This README is a good starting point. I would prefer if it focused a bit more on the high level architecture and terminology, instead of going straight into structs and specific function names.
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor-readme
branch
from
September 15, 2026 09:10
2f8d24b to
6e1c710
Compare
larsewi
approved these changes
Sep 15, 2026
| Rather than exposing the raw file-descriptor bookkeeping required for `select(2)`, we introduce a unified interface that serves both the reactor-plugin and event-driven code paths. This is achieved by encapsulating all relevant state in a context struct, `ReactorContext`: | ||
|
|
||
| ```C | ||
| typedef struct ReactorContext |
Contributor
There was a problem hiding this comment.
Would it make sense to have two Seq *, one for reactor-plugin FDs, and one for the other FDs? Or perhaps one Seq * where FDs are wrapped in a struct with flags determining who owns them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.