Fixed stoppable_thread_test error and hide watcher_test error msg - #6367
Merged
Merged
Conversation
victormlg
force-pushed
the
cf-reactor-ci-errors
branch
from
September 24, 2026 09:04
2c82410 to
1da9d0f
Compare
Contributor
|
@cf-bottom Jenkins please :) |
1. stoppable_thread_test.c: There was a race condition in test_stop_running_thread, which expected the thread to run at least one iteration before being stopped. ThreadedQueuePush was used to signal that the thread had started, but it was called before the loop, so the test could stop the thread before its first iteration. 2. watcher_test.c, stoppable_thread_test.c: Code intended to fail was logging error instead of capturing the output. Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor-ci-errors
branch
from
September 24, 2026 09:51
1da9d0f to
6922c75
Compare
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14699/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14699/ |
larsewi
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.