Added description of when files promisers are interpreted as regular expressions#3745
Open
nickanderson wants to merge 1 commit into
Open
Added description of when files promisers are interpreted as regular expressions#3745nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
nickanderson
force-pushed
the
docs-promiser-regex-detection
branch
from
July 23, 2026 18:02
9d1ebc1 to
8901399
Compare
olehermanse
reviewed
Jul 24, 2026
| character literal). So `/tmp/test.txt` matches only `/tmp/test.txt`, not | ||
| `/tmp/test-txt`. | ||
|
|
||
| When regular expression is chosen the entire promiser is converted into a |
Member
There was a problem hiding this comment.
How do you choose regular expression?
Member
Author
There was a problem hiding this comment.
Here, I simplified it what do you think now
olehermanse
requested changes
Jul 24, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Not clear to me what you mean by choosing regular expression.
…expressions Files promises by default guess if they are meant to be interpreted as a regular expression or not and this adds explicit description of what that guess is based on.
nickanderson
force-pushed
the
docs-promiser-regex-detection
branch
from
July 24, 2026 19:29
dbd8fdf to
4d05c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files promises by default guess if they are meant to be interpreted as a regular
expression or not and this adds explicit description of what that guess is based
on.