Remove global warning suppression, replace with targeted filters - #164
Draft
ch55secake with Copilot wants to merge 2 commits into
Draft
Remove global warning suppression, replace with targeted filters#164ch55secake with Copilot wants to merge 2 commits into
ch55secake with Copilot wants to merge 2 commits into
Conversation
…uppressions - src/main.py: remove blanket warning suppression (and unused import warnings) - src/optimise/optimizer.py: replace blanket suppression with targeted filters for UserWarning/FutureWarning from xgboost and lightgbm, and optuna.exceptions.ExperimentalWarning, scoped to only the known-noisy warnings from those ML libraries Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/b5bb67ea-166b-45cb-9595-734ef3bf88eb Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove blanket suppression of all Python warnings
Remove global warning suppression, replace with targeted filters
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
warnings.filterwarnings("ignore")was applied globally in two modules, silently swallowing deprecation notices, convergence warnings, and data quality signals from pandas/numpy/sklearn — making failures harder to diagnose.Changes in this pull request
src/main.py: Removed blanketwarnings.filterwarnings("ignore")and the now-unusedimport warnings. The entry-point has no reason to suppress warnings globally.src/optimise/optimizer.py: Replaced the blanket suppression with four targeted filters scoped to known-noisy-but-harmless library internals that would otherwise flood logs across thousands of Optuna trials:All other warnings — convergence failures, deprecations, pandas
PerformanceWarning, etc. — now surface as intended.