[WIP] Audit Hyperion codebase for bugs, performance, and security issues - #197
Draft
ch55secake with Copilot wants to merge 3 commits into
Draft
[WIP] Audit Hyperion codebase for bugs, performance, and security issues#197ch55secake with Copilot wants to merge 3 commits into
ch55secake with Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/2ba94272-39fb-4e75-9898-8de089ad295c Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/2ba94272-39fb-4e75-9898-8de089ad295c Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.pyfile paths (S-1): validate ticker against^[A-Z0-9.\-]{1,10}$and assert resolved path stays insideresults/debug=Trueon public-facing Flask server (S-2):debugnow reads fromFLASK_DEBUGenv var, defaults tofalseUnboundLocalErrorwhen walk-forward fallback triggers (B-1): initialisewf_results = {}in theexceptbranchpred_lenignoresmin_lencausing potential misalignment insimulate()(B-3):pred_len = min_lendoji()divide-by-zero whenhigh == low(B-4): use.replace(0, np.nan)in denominator_get_stock_info()(B-5): hold_lockduring check-and-set; catch fetch errors and store empty dictoptimizer.pybypasses logger singleton; blanketwarnings.filterwarnings("ignore")(CQ-3): importfrom src.util import logger; replace blanket suppression with targeted filtersprint()calls instacked_pipeline.pyandranker.py→logger.*()(CQ-1); ranking table consolidated into a singlelogger.infocall to reduce log noisetraceback.print_exc()calls →logger.exception()inbase_pipeline.py,stacked_pipeline.py,time_series_stacked_pipeline.py(CQ-2); removed now-unusedimport traceback