Wire val_size through CLI and pipeline construction - #203
Draft
ch55secake with Copilot wants to merge 3 commits into
Draft
Wire val_size through CLI and pipeline construction#203ch55secake with Copilot wants to merge 3 commits into
val_size through CLI and pipeline construction#203ch55secake with Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/062d4822-53bc-4082-af4b-0e9e92eb97ef Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/062d4822-53bc-4082-af4b-0e9e92eb97ef Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Audit Hyperion codebase for various issues
Wire Apr 23, 2026
val_size through CLI and pipeline construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Daily audit found a split-configuration gap:
HyperionConfig.val_sizeexisted but was not reachable from CLI/Makefile and was not propagated into pipeline construction. This made validation split control effectively non-functional at runtime.Changes in this pull request
CLI + config propagation
--val-sizetosrc/main.pyargument parsing.HyperionConfig(val_size=...).config.val_sizeinto bothStackedModelTrainingPipelineandTimeSeriesStackedModelTrainingPipeline.Makefile runtime parity
VAL_SIZE ?= 0.1.--val-size $(VAL_SIZE)in_RUN_ARGSsomake runcan control validation split.Regression coverage
tests/test_main.pyto assert:val_sizeis preserved when no CLI override is provided,--val-sizeis parsed and applied.