Skip to content

Wire val_size through CLI and pipeline construction - #203

Draft
ch55secake with Copilot wants to merge 3 commits into
mainfrom
copilot/audit-hyperion-codebase-2026-04-23
Draft

Wire val_size through CLI and pipeline construction#203
ch55secake with Copilot wants to merge 3 commits into
mainfrom
copilot/audit-hyperion-codebase-2026-04-23

Conversation

Copilot AI commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description

Daily audit found a split-configuration gap: HyperionConfig.val_size existed but was not reachable from CLI/Makefile and was not propagated into pipeline construction. This made validation split control effectively non-functional at runtime.

Changes in this pull request

  • CLI + config propagation

    • Added --val-size to src/main.py argument parsing.
    • Mapped parsed value into HyperionConfig(val_size=...).
    • Passed config.val_size into both StackedModelTrainingPipeline and TimeSeriesStackedModelTrainingPipeline.
  • Makefile runtime parity

    • Added VAL_SIZE ?= 0.1.
    • Included --val-size $(VAL_SIZE) in _RUN_ARGS so make run can control validation split.
  • Regression coverage

    • Added tests/test_main.py to assert:
      • default val_size is preserved when no CLI override is provided,
      • custom --val-size is parsed and applied.
parser.add_argument(
    "--val-size",
    type=float,
    default=defaults.val_size,
    help="Fraction of data reserved for validation (0 < val_size < 1); train_size = 1 - test_size - val_size.",
)

Copilot AI linked an issue Apr 23, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits April 23, 2026 08:46
Copilot AI changed the title [WIP] Audit Hyperion codebase for various issues Wire val_size through CLI and pipeline construction Apr 23, 2026
Copilot AI requested a review from ch55secake April 23, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily Audit: 2026-04-23

2 participants