Repository navigation
fix(trade): sell what a curve's real reserves can pay, explain buys past the curve - #28
Merged
Merged
Conversation
…ast the curve A sell larger than the curve's real reserves reverted; it now sells the most they cover and reports the rest. A buy past the curve's remaining tokens now says how many are left instead of a raw program error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
smypmsa
added a commit
that referenced
this pull request
Nov 9, 2026
* fix(migrate): pass the new pool's boost vault accounts to migrate_v2 (#27) PumpSwap creates the pool's boost vault during the migration and reverts without its authority and quote token account, which the IDL doesn't list. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(trade): sell what a curve's real reserves can pay, explain buys past the curve (#28) A sell larger than the curve's real reserves reverted; it now sells the most they cover and reports the rest. A buy past the curve's remaining tokens now says how many are left instead of a raw program error. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat: buy, sell and info for Raydium LaunchLab coins (#29) A mint with no pump.fun curve is looked up on LaunchLab, under any launchpad's platform config and any quote asset, with Token-2022 transfer fees counted. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat: trade graduated LaunchLab coins on Raydium CPMM (#30) buy and sell follow a graduated LaunchLab coin to its CPMM pool, the way they follow a pump.fun coin to PumpSwap; --force-amm covers both, and info shows the pool. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * chore: release 0.3.0 (#31) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pump.fun prices a sell on the curve's virtual reserves but pays it out of its real reserves, and on some coins (mayhem mode) the two drift apart. A sell worth more than the real reserves reverted.
sellnow sells the most the curve can pay for and reports the rest astokens_kept, or sends nothing (curve_short) when the curve can pay nothing. A buy that asks for more tokens than the curve has left now returnsexceeds_curvewith the tokens left, instead of the raw 6021 error.Verified with unit tests and on surfpool: with a curve's real reserves lowered, the capped sell lands and one more token reverts with 6024.