Repository navigation
fix(cpmm): keep a sent but unconfirmed trade's signature under --force-amm - #34
Merged
Merged
Conversation
…e-amm Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--force-ammon a LaunchLab coin falls back to CPMM when there is no PumpSwap pool, and kept PumpSwap's "no pool" error when CPMM returned a generic error. A CPMM trade that was sent but could not be confirmed came back as that generic error, so its signature was dropped and the user could trade twice. A sent but unconfirmed trade is now its own error, which the routing always passes on. Also checks the surfpool cheatcode response in the reserve-cap test.Verified with unit tests (the new ones fail without the change) and the surfpool test.