Skip to content

fix(cpmm): keep a sent but unconfirmed trade's signature under --force-amm - #34

Merged
smypmsa merged 1 commit into
v3-nextfrom
fix/force-amm-unconfirmed
Nov 9, 2026
Merged

smypmsa merged 1 commit into
v3-nextfrom
fix/force-amm-unconfirmed

Conversation

@smypmsa

@smypmsa smypmsa commented Nov 9, 2026

Copy link
Copy Markdown
Member

--force-amm on a LaunchLab coin falls back to CPMM when there is no PumpSwap pool, and kept PumpSwap's "no pool" error when CPMM returned a generic error. A CPMM trade that was sent but could not be confirmed came back as that generic error, so its signature was dropped and the user could trade twice. A sent but unconfirmed trade is now its own error, which the routing always passes on. Also checks the surfpool cheatcode response in the reserve-cap test.

Verified with unit tests (the new ones fail without the change) and the surfpool test.

…e-amm

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@smypmsa
smypmsa merged commit 07d15c4 into v3-next Nov 9, 2026
6 checks passed
@smypmsa
smypmsa deleted the fix/force-amm-unconfirmed branch November 9, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant