修复技能包下载导致的连接池饥饿 - #1331
Merged
Merged
修复技能包下载导致的连接池饥饿#1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Agent 并发下载技能包时，资源权限校验事务会一直持有数据库连接，随后技能下载又通过连接池查询一次元数据。连接池容量较小时，多个请求会各自持有一个连接并等待第二个连接，导致鉴权查询超时、接口返回 503，下载请求最终被客户端取消并记录为 499。
修改
验证
go test ./...git diff --check