Repository navigation
test: do not ignore errors in add_pseudo_transport() - #8811
Merged
Merged
Conversation
link2xt
marked this pull request as ready for review
October 7, 2026 13:30
hpk42
reviewed
Oct 7, 2026
| tcm.section("Test switching back"); | ||
| tcm.change_addr(alice, "alice@example.org").await; | ||
| alice | ||
| .set_primary_self_addr("alice@example.org") |
Contributor
There was a problem hiding this comment.
i cringe a bit at seeing added "primary" wording after working so long to remove it. Not in this PR but maybe we can rename it to "set_single_self_addr"?
Collaborator
Author
There was a problem hiding this comment.
It is replaced with TestContext.set_sending_addr() in #8711, better name can be chosen there once it is finished, but most tests should not even need to call it.
hpk42
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.