Repository navigation
Conversation
This is simpler and can count as hardening because we don't call async_zip parser anymore just to check if received file is a webxdc. This way if ZIP parser is buggy and e.g. panics, or gets into infinite loop, or is accidentally quadratic, or allocates a lot of memory, this cannot be triggered by just sending a file.
link2xt
force-pushed
the
link2xt/webxdc-detect-by-mime-type
branch
from
October 13, 2026 03:28
7e16683 to
4e2ee61
Compare
link2xt
marked this pull request as ready for review
October 13, 2026 03:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simpler and can count as hardening because we don't call async_zip parser anymore just to check if received file is a webxdc. This way if ZIP parser is buggy and e.g. panics, or gets into infinite loop, or is accidentally quadratic, or allocates a lot of memory, this cannot be triggered by just sending a file.
Make sure to enable "hide whitespace" when reviewing, rustfmt decided to reformat everything.