Skip to content

fix(setups): send pay by bank under the paybybank key - #252

Merged
armando-rodriguez-cko merged 1 commit into
mainfrom
fix/INT-1717-paybybank-key
Oct 15, 2026
Merged

armando-rodriguez-cko merged 1 commit into
mainfrom
fix/INT-1717-paybybank-key

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
The Payment Setup API names the Pay by Bank method paybybank. This SDK sent it as pay_by_bank, which the API ignores without an error, so Pay by Bank configuration was silently dropped. This PR sends the correct key and adds the risk object (enabled).

Changes

  • payments/setups/setups.py: new paybybank; pay_by_bank kept and marked deprecated (the API ignores that key); new PaymentSetupRisk (enabled) and PaymentSetupsRequest.risk
  • payments/setups/setups_client.py: docstrings point to payment_methods.paybybank and risk
  • tests/payments/setups/payment_setups_serialization_test.py: literal key, response action, risk serialization

API Reference

Breaking changes
None. pay_by_bank is deprecated, not removed; it will be removed in a future major.

README
No change needed.

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 14, 2026 10:28
@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR adds a new field alias (paybybank), a small new data class (PaymentSetupRisk), and a new request field (risk) that are all natural extensions of existing abstractions on the same endpoint, with no new external integrations, auth changes, persisted data, or background processes.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 3


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The PR adds a new field alias (paybybank), a small new data class (PaymentSetupRisk), and a new request field (risk) that are all natural extensions of existing abstractions on the same endpoint, with no new external integrations, auth changes, persisted data, or background processes. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

The Payment Setup API names the Pay by Bank method paybybank; the old key
is ignored without an error. Also adds the risk object (enabled).
@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds a new field alias (paybybank) to an existing data class, deprecates an incorrect field (pay_by_bank), adds a small new data class (PaymentSetupRisk) with a single bool field to an existing request object, and updates docstrings — all reusing existing endpoints, abstractions, and code paths with no new external integrations, persisted data, auth changes, or background processes.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 3


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change only adds a new field alias (paybybank) to an existing data class, deprecates an incorrect field (pay_by_bank), adds a small new data class (PaymentSetupRisk) with a single bool field to an existing request object, and updates docstrings — all reusing existing endpoints, abstractions, and code paths with no new external integrations, persisted data, auth changes, or background processes. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds a correctly-named field alias (paybybank) alongside the deprecated pay_by_bank, adds a small PaymentSetupRiskdata class with a single bool field, wiresrisk into the existing request object, and updates docstrings—all within the existing endpoints, abstractions, and serialization path with no new external integrations, persisted data, auth changes, or background processes.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@armando-rodriguez-cko
armando-rodriguez-cko merged commit cf0f506 into main Oct 15, 2026
4 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the fix/INT-1717-paybybank-key branch October 15, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants