Repository navigation
fix(setups): send pay by bank under the paybybank key - #252
Conversation
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 3 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
The Payment Setup API names the Pay by Bank method paybybank; the old key is ignored without an error. Also adds the risk object (enabled).
034d74a to
6140b51
Compare
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 3 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The change only adds a correctly-named field alias (paybybank) alongside the deprecatedpay_by_bank, adds a smallPaymentSetupRiskdata class with a single bool field, wiresriskinto the existing request object, and updates docstrings—all within the existing endpoints, abstractions, and serialization path with no new external integrations, persisted data, auth changes, or background processes.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…



Summary
The Payment Setup API names the Pay by Bank method
paybybank. This SDK sent it aspay_by_bank, which the API ignores without an error, so Pay by Bank configuration was silently dropped. This PR sends the correct key and adds theriskobject (enabled).Changes
payments/setups/setups.py: newpaybybank;pay_by_bankkept and marked deprecated (the API ignores that key); newPaymentSetupRisk(enabled) andPaymentSetupsRequest.riskpayments/setups/setups_client.py: docstrings point topayment_methods.paybybankandrisktests/payments/setups/payment_setups_serialization_test.py: literal key, responseaction,riskserializationAPI Reference
POST /payments/setups: payment_methods.paybybank, riskPUT /payments/setups/{id}: payment_methods.paybybank, riskGET /payments/setups/{id}Breaking changes
None.
pay_by_bankis deprecated, not removed; it will be removed in a future major.README
No change needed.